From owner-svn-src-head@FreeBSD.ORG  Wed Jun 20 21:15:26 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 452AB1065670
	for <svn-src-head@freebsd.org>; Wed, 20 Jun 2012 21:15:26 +0000 (UTC)
	(envelope-from wlosh@bsdimp.com)
Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com
	[209.85.160.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 0E3C48FC1F
	for <svn-src-head@freebsd.org>; Wed, 20 Jun 2012 21:15:26 +0000 (UTC)
Received: by pbbro2 with SMTP id ro2so1290367pbb.13
	for <svn-src-head@freebsd.org>; Wed, 20 Jun 2012 14:15:25 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=google.com; s=20120113;
	h=subject:mime-version:content-type:from:in-reply-to:date:cc
	:content-transfer-encoding:message-id:references:to:x-mailer
	:x-gm-message-state;
	bh=n2mAkYYH1H2kamlAz3EniseVJXGHI7N0jq/5RY4zn6o=;
	b=d/v1Zupe+NEY0wyYm62NkEndqUdQDrzIPA1Du0c6Xe6OdKmuOPWbogd2Cazonj8By3
	9cs/XLjNQJ31i0pW7fnwSgnYy1d7cM0GuxThLhA+1FnQzRh98RuYNM1L0RCzMw7n07dE
	Mb225vfnEuLT58YWlnAUi6nTUeP6RuVxwTTE2eewMdFuV5RpUEgUhP3eKVNjnS7JcPDR
	J1S5lB+9cqHuSdRXG2YbHQIMGt2FoPsitBZbVlWwjYgpAKmGBtaQLFOZXfI6rTpIvTrI
	OaL7xLDP3ogL0iRtK3yFBYwEqnEFvIyKpQ/1PYQrR+Y1orMUirRNODg3t4yUYAmNUKO2
	9HvA==
Received: by 10.68.231.40 with SMTP id td8mr82026057pbc.150.1340226925859;
	Wed, 20 Jun 2012 14:15:25 -0700 (PDT)
Received: from [10.30.101.53] ([209.117.142.2])
	by mx.google.com with ESMTPS id he9sm33186270pbc.68.2012.06.20.14.15.24
	(version=TLSv1/SSLv3 cipher=OTHER);
	Wed, 20 Jun 2012 14:15:25 -0700 (PDT)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Warner Losh <wlosh@bsdimp.com>
In-Reply-To: <4FE1FC23.9000904@freebsd.org>
Date: Wed, 20 Jun 2012 15:15:17 -0600
Content-Transfer-Encoding: 7bit
Message-Id: <690DF487-F7CB-421E-B6BC-F7CE6BC0F658@bsdimp.com>
References: <201206200638.q5K6cg7u024024@svn.freebsd.org>
	<20120621015220.J2636@besplex.bde.org>
	<4FE1FC23.9000904@freebsd.org>
To: Colin Percival <cperciva@FreeBSD.org>
X-Mailer: Apple Mail (2.1084)
X-Gm-Message-State: ALoCoQmnSeM7U/EFBiUtP+u7unl//YdtXimKCUmqnl5Ug4pbpDOCBWkSaVeyZ7nMTY9MF+F3p/CT
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Eitan Adler <eadler@freebsd.org>,
	Bruce Evans <brde@optusnet.com.au>
Subject: Re: svn commit: r237286 - head/lib/libc/gen
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jun 2012 21:15:26 -0000


On Jun 20, 2012, at 10:36 AM, Colin Percival wrote:

> On 06/20/12 09:27, Bruce Evans wrote:
>> On Wed, 20 Jun 2012, Eitan Adler wrote:
>>> Log:
>>> Don't close an uninitialized descriptor. [1]
>>> Add a sanity check for the validity of the passed fd.
>> 
>> Library functions shouldn't use assert() or abort().
> 
> Why not?

We've tried to avoid things that make the library dump core...

Warner