From owner-freebsd-virtualization@FreeBSD.ORG  Sat Mar 28 05:49:12 2015
Return-Path: <owner-freebsd-virtualization@FreeBSD.ORG>
Delivered-To: freebsd-virtualization@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 627A1A1C
 for <freebsd-virtualization@freebsd.org>; Sat, 28 Mar 2015 05:49:12 +0000 (UTC)
Received: from mail-ig0-x232.google.com (mail-ig0-x232.google.com
 [IPv6:2607:f8b0:4001:c05::232])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2711911E
 for <freebsd-virtualization@freebsd.org>; Sat, 28 Mar 2015 05:49:12 +0000 (UTC)
Received: by igcau2 with SMTP id au2so43211548igc.1
 for <freebsd-virtualization@freebsd.org>; Fri, 27 Mar 2015 22:49:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:content-type;
 bh=47kwJJiiT6azrRvvT59ZpkQGWGUWU6OwphUQRj27i4Y=;
 b=QWxUS1e0JIuGsO9v2ZAeP07+MKHQlJRf4XLU5RxJY3RJN02fiw/fDkjZpbp2dbwq9d
 vgbOErwmwIh+IsRIsWr2TgMo9qisT0YcoztbH9kHn3h3xvX0Fh1c3XtYc09nyzEMsRrK
 kir/e4C6z7eRBYaEBX7NUx+lV+X8/Kur7RUuF/0KfyRqPxzYWqU2yTbYEwBRK3ZE1K/P
 rewWh28iJecehMr/gHPStsc9ptfg1IW/lqE6/qcqZcpawtR594ggzB81k/0xyEl0U/dC
 mlT4uF7dYqFI25pN0gQufqdGjxuOjDLkJYBO2NuKUgAMMKHbZgRdpbs6KPCSlqfRBP86
 S3og==
X-Received: by 10.107.168.146 with SMTP id e18mr10232088ioj.32.1427521751123; 
 Fri, 27 Mar 2015 22:49:11 -0700 (PDT)
MIME-Version: 1.0
Sender: jtubnor@gmail.com
Received: by 10.36.96.4 with HTTP; Fri, 27 Mar 2015 22:48:50 -0700 (PDT)
In-Reply-To: <CAFgRE9GHAMPUk858dvtd-ojZLaftnFmfVfaWwBAmSTqAjmrPSQ@mail.gmail.com>
References: <metut1$b1f$1@ger.gmane.org>
 <CAFgRE9GHAMPUk858dvtd-ojZLaftnFmfVfaWwBAmSTqAjmrPSQ@mail.gmail.com>
From: Jason Tubnor <jason@tubnor.net>
Date: Sat, 28 Mar 2015 16:48:50 +1100
X-Google-Sender-Auth: rfeZ87CHYNaoPwFN5zp8AMq9Cow
Message-ID: <CACLnyCKj5LPwWgtD8AxhBS-b41Kn+BuqJoDC6V3MEkGnXmSgrw@mail.gmail.com>
Subject: Re: Several bhyve quirks
To: Neel Natu <neelnatu@gmail.com>, 
 "freebsd-virtualization@freebsd.org" <freebsd-virtualization@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: freebsd-virtualization@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "Discussion of various virtualization techniques FreeBSD supports."
 <freebsd-virtualization.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-virtualization>, 
 <mailto:freebsd-virtualization-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-virtualization/>
List-Post: <mailto:freebsd-virtualization@freebsd.org>
List-Help: <mailto:freebsd-virtualization-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>, 
 <mailto:freebsd-virtualization-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Mar 2015 05:49:12 -0000

On 28 March 2015 at 10:49, Neel Natu <neelnatu@gmail.com> wrote:
>
> This is fixed in HEAD where the RTC device model defaults to 24-hour time.
>
>> <https://github.com/freebsd/freebsd/commit/b341fa888c7a3b71ef8fb36ed40f08b7ceb8c486>
>> suggests that I'm on the right track, but it doesn't explain the off-by-one
>> nor the (one time) multi-day offset.
>>
>
> The one-hour offset is a bug due to my interpretation of the 12-hour format.
>
> I am going to fix this in HEAD shortly but here is a patch for 10.1 and earlier:
> https://people.freebsd.org/~neel/patches/bhyve_openbsd_rtc.patch
>

Thanks for this Neel.  I was trying to back port your original HEAD
patch into 10.1 but there were too many quirks to deal with into other
dependent libs.  I didn't have the skills to do this, it is
appreciated that you did it :-)  Thanks!