From owner-svn-src-head@freebsd.org Tue Feb 27 09:06:48 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 77D1DF32812 for ; Tue, 27 Feb 2018 09:06:48 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yb0-x242.google.com (mail-yb0-x242.google.com [IPv6:2607:f8b0:4002:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1717E6ABAE for ; Tue, 27 Feb 2018 09:06:48 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yb0-x242.google.com with SMTP id i13-v6so6288317ybl.9 for ; Tue, 27 Feb 2018 01:06:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=DFbC4bkOOgNkD/0kU5smOt0mwDQZgEbBDluiHDBgrow=; b=cIaah8HccSM2w6DuOXdd8raeXbUXtKd1R74lEECMat4kMxKoa6HymwxXvRw1oieinG mtPAsImOXCdvFQnHFDvTbcv8AD7BtONJoQ/rxfCrXopANgNQhMlRk18rN1lL4k5VaiB7 n0IUiMtqH8CfnIBWyeeTtzGueMP3wJGES3fQI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DFbC4bkOOgNkD/0kU5smOt0mwDQZgEbBDluiHDBgrow=; b=eAus3ar2L+c3ICW970rMpN6husf4g6NSxI9nHdh1H2hXvvKVSKwKu/IbJc2wBpNv79 7S3QZ8/YAlxGXZqWfuRXZw89Yjj9hTfZpQ9g5k2zVN6w0f6DfHoDiKnWwK2WbCScSj3/ 47Fl4rpESlRYwT6YzgP0+kStRP1rH8bb4/YwxbtarFafqvYqCPAI3JTtk+UtxxR66+9o dZxI1CTrqFCUiBYBrovyRwCi8I2j2Cd/4T5zTZFU7FA/RI53ZFQR78decvZ/ws/S3VjQ BAvteEVZ7Bxz5A6iah1b9M+RY5v8VxLLrNb6oAKIv2kt0MjZO8j8m3YXSVmQivMIbn1R U/Eg== X-Gm-Message-State: APf1xPDEL48K4ffItw4QL0UIFuGtI3wCskkkrHfVrEfJMnOpFaJDnc0A yVMrt+BBVOq0njjXS+uVhVa165Sw8cxha4H4y8RJ1g== X-Google-Smtp-Source: AG47ELsCq/T3KiwGTdeMGyN0SSMZpB2eBGv0pEXULEc06XYJZs01Ip0ivgQYrBtGepxaB3nOA2iqCfWF+eQ0IA7mWro= X-Received: by 2002:a25:86c5:: with SMTP id y5-v6mr8928332ybm.194.1519722407100; Tue, 27 Feb 2018 01:06:47 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a25:dfcb:0:0:0:0:0 with HTTP; Tue, 27 Feb 2018 01:06:16 -0800 (PST) In-Reply-To: <201710091548.v99FmuuT046501@repo.freebsd.org> References: <201710091548.v99FmuuT046501@repo.freebsd.org> From: Eitan Adler Date: Tue, 27 Feb 2018 01:06:16 -0800 Message-ID: Subject: Re: svn commit: r324434 - in head/sys: dev/iwm modules/iwmfw/iwm8265fw To: "George V. Neville-Neil" , Adrian Chadd , Cooper Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2018 09:06:48 -0000 Hi all, I was looking what it would take to MFC this and it seems to be spread across several commits. The following is an incomplete list: - r314073 - r314074 - r314076 - r314082 - r314192 - r321508 - r321509 - r321510 (a) What other commits am I missing? (b) How much of this is actually safe to MFC? Many of the commits are not marked as 'mfc after' and it seems to be undergoing a lot of change. On 9 October 2017 at 08:48, George V. Neville-Neil wrote: > Author: gnn > Date: Mon Oct 9 15:48:56 2017 > New Revision: 324434 > URL: https://svnweb.freebsd.org/changeset/base/324434 > > Log: > Add support for Intel 8265 WiFi > > Obtained from: OpenBSD > MFC after: 1 month > > Added: > head/sys/modules/iwmfw/iwm8265fw/ > head/sys/modules/iwmfw/iwm8265fw/Makefile (contents, props changed) > Modified: > head/sys/dev/iwm/if_iwm.c > head/sys/dev/iwm/if_iwm_8000.c > head/sys/dev/iwm/if_iwm_config.h > > Modified: head/sys/dev/iwm/if_iwm.c > ============================================================================== > --- head/sys/dev/iwm/if_iwm.c Mon Oct 9 15:39:43 2017 (r324433) > +++ head/sys/dev/iwm/if_iwm.c Mon Oct 9 15:48:56 2017 (r324434) > @@ -1,4 +1,4 @@ > -/* $OpenBSD: if_iwm.c,v 1.42 2015/05/30 02:49:23 deraadt Exp $ */ > +/* $OpenBSD: if_iwm.c,v 1.167 2017/04/04 00:40:52 claudio Exp $ */ > > /* > * Copyright (c) 2014 genua mbh > @@ -5690,6 +5690,7 @@ iwm_intr(void *arg) > #define PCI_PRODUCT_INTEL_WL_7265_2 0x095b > #define PCI_PRODUCT_INTEL_WL_8260_1 0x24f3 > #define PCI_PRODUCT_INTEL_WL_8260_2 0x24f4 > +#define PCI_PRODUCT_INTEL_WL_8265_1 0x24fd > > static const struct iwm_devices { > uint16_t device; > @@ -5705,6 +5706,7 @@ static const struct iwm_devices { > { PCI_PRODUCT_INTEL_WL_7265_2, &iwm7265_cfg }, > { PCI_PRODUCT_INTEL_WL_8260_1, &iwm8260_cfg }, > { PCI_PRODUCT_INTEL_WL_8260_2, &iwm8260_cfg }, > + { PCI_PRODUCT_INTEL_WL_8265_1, &iwm8265_cfg }, > }; > > static int > > Modified: head/sys/dev/iwm/if_iwm_8000.c > ============================================================================== > --- head/sys/dev/iwm/if_iwm_8000.c Mon Oct 9 15:39:43 2017 (r324433) > +++ head/sys/dev/iwm/if_iwm_8000.c Mon Oct 9 15:48:56 2017 (r324434) > @@ -79,6 +79,7 @@ __FBSDID("$FreeBSD$"); > #include "if_iwm_config.h" > > #define IWM8000_FW "iwm8000Cfw" > +#define IWM8265_FW "iwm8265fw" > > #define IWM_NVM_HW_SECTION_NUM_FAMILY_8000 10 > > @@ -90,6 +91,13 @@ __FBSDID("$FreeBSD$"); > const struct iwm_cfg iwm8260_cfg = { > .name = "Intel(R) Dual Band Wireless AC 8260", > .fw_name = IWM8000_FW, > + IWM_DEVICE_8000_COMMON, > + .host_interrupt_operation_mode = 0, > +}; > + > +const struct iwm_cfg iwm8265_cfg = { > + .name = "Intel(R) Dual Band Wireless AC 8265", > + .fw_name = IWM8265_FW, > IWM_DEVICE_8000_COMMON, > .host_interrupt_operation_mode = 0, > }; > > Modified: head/sys/dev/iwm/if_iwm_config.h > ============================================================================== > --- head/sys/dev/iwm/if_iwm_config.h Mon Oct 9 15:39:43 2017 (r324433) > +++ head/sys/dev/iwm/if_iwm_config.h Mon Oct 9 15:48:56 2017 (r324434) > @@ -131,5 +131,6 @@ extern const struct iwm_cfg iwm3165_cfg; > extern const struct iwm_cfg iwm7265_cfg; > extern const struct iwm_cfg iwm7265d_cfg; > extern const struct iwm_cfg iwm8260_cfg; > +extern const struct iwm_cfg iwm8265_cfg; > > #endif /* __IWM_CONFIG_H__ */ > > Added: head/sys/modules/iwmfw/iwm8265fw/Makefile > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/sys/modules/iwmfw/iwm8265fw/Makefile Mon Oct 9 15:48:56 2017 (r324434) > @@ -0,0 +1,6 @@ > +# $FreeBSD$ > + > +KMOD= iwm8265fw > +IMG= iwm-8265-22 > + > +.include > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" -- Eitan Adler