From owner-freebsd-current@FreeBSD.ORG  Fri Sep 16 21:12:30 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 24FAD1065670;
	Fri, 16 Sep 2011 21:12:30 +0000 (UTC)
	(envelope-from lacombar@gmail.com)
Received: from mail-gw0-f50.google.com (mail-gw0-f50.google.com [74.125.83.50])
	by mx1.freebsd.org (Postfix) with ESMTP id C8BC28FC0C;
	Fri, 16 Sep 2011 21:12:29 +0000 (UTC)
Received: by gwj16 with SMTP id 16so4400680gwj.37
	for <multiple recipients>; Fri, 16 Sep 2011 14:12:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type:content-transfer-encoding;
	bh=83+95i5o3Rl0o8bwe4uXaarFLGMNLc7V3fQu+BEX0ys=;
	b=ArMMBALG2TPEOGou9lb/qRO22vKv+4de2eLAB5ObsjIBZZvZWU32xXp5zEpdhkROUU
	gwED9GQ/7lHabvP5NEZl8PlQNZBbuYLLfG8bLswBiUWu7TqMiwyrggCfITLFuIwQq1vG
	zt/5QdIFY/g/h3NwCHU2MczGqnICVHjFlQF+o=
MIME-Version: 1.0
Received: by 10.68.71.200 with SMTP id x8mr2535003pbu.465.1316207548574; Fri,
	16 Sep 2011 14:12:28 -0700 (PDT)
Received: by 10.142.12.18 with HTTP; Fri, 16 Sep 2011 14:12:28 -0700 (PDT)
In-Reply-To: <20110916194012.GB9916@michelle.cdnetworks.com>
References: <CACqU3MWYa7awOO0x1jPNyXq2gccYAL+5wzkE6nOqsNGdP0GyeA@mail.gmail.com>
	<20110916194012.GB9916@michelle.cdnetworks.com>
Date: Fri, 16 Sep 2011 17:12:28 -0400
Message-ID: <CACqU3MXjbc=vy-Miij2K9N+MHJWNbWXB7+oh3hstzy2-orJDwg@mail.gmail.com>
From: Arnaud Lacombe <lacombar@gmail.com>
To: pyunyh@gmail.com
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-net@freebsd.org, FreeBSD-Current <freebsd-current@freebsd.org>
Subject: Re: Queue drop not accounted ?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Sep 2011 21:12:30 -0000

Hi,

On Fri, Sep 16, 2011 at 3:40 PM, YongHyeon PYUN <pyunyh@gmail.com> wrote:
> On Thu, Sep 15, 2011 at 09:25:19PM -0400, Arnaud Lacombe wrote:
>> Hi,
>>
>> Shouldn't packet freed in IFQ_ENQUEUE() because the queue is full be
>> accounted as dropped, cf attached patch ?
>>
>
> Hmm, I think err would be set to ENOBUFS for queue full case and
> this err will crease ifq_drops.
>
oh, yeah, I missed the increment not using the accessors after the branch.

A.

>> Thanks,
>> =A0- Arnaud
>