From owner-freebsd-ports@FreeBSD.ORG Sat Mar 8 06:19:15 2008 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BBB23106566B for ; Sat, 8 Mar 2008 06:19:15 +0000 (UTC) (envelope-from carpetsmoker@phong.rwxrwxrwx.net) Received: from phong.rwxrwxrwx.net (rwxrwxrwx.net [82.93.23.199]) by mx1.freebsd.org (Postfix) with ESMTP id 1E6938FC1E for ; Sat, 8 Mar 2008 06:19:14 +0000 (UTC) (envelope-from carpetsmoker@phong.rwxrwxrwx.net) Received: from phong.rwxrwxrwx.net (localhost [127.0.0.1]) by phong.rwxrwxrwx.net (8.14.2/8.14.2) with ESMTP id m285rrVE041278; Sat, 8 Mar 2008 06:53:54 +0100 (CET) (envelope-from carpetsmoker@phong.rwxrwxrwx.net) Received: (from carpetsmoker@localhost) by phong.rwxrwxrwx.net (8.14.2/8.14.2/Submit) id m285rrdv041277; Sat, 8 Mar 2008 06:53:53 +0100 (CET) (envelope-from carpetsmoker) Date: Sat, 8 Mar 2008 06:53:52 +0100 From: Martin Tournoij To: freebsd-ports@freebsd.org Message-ID: <20080308055352.GA21893@phong.rwxrwxrwx.net> Mail-Followup-To: freebsd-ports@freebsd.org, tigner@msu.edu References: <20080306080053.GA93915@pin.if.uz.zgora.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20080306080053.GA93915@pin.if.uz.zgora.pl> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: tigner@msu.edu Subject: Re: FreeBSD-games/Larn is broken in FreeBSD7.0 Release X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Mar 2008 06:19:15 -0000 On Thu, Mar 06, 2008 at 09:00:53AM +0100, Edward Tomasz Napierala wrote: > In article you wrote: > >>> When you run Larn, and chose to read/eat/drink anything the games exits > >>> with a signal 11 ,segfaults and does a coredump. > >>> > >>> You have found a magic potion > >>> Do you (d) drink it, (t) take it, or (i) ignore it? > >>> Segmentation fault (core dumped) [SIGSEGV]drink > >>> > >>> I would like to use Larn on 7.0, what do I suggest I do to fix this ? > >> > >> This is caused by the same problem as freebsd-games/hack. > >> Please refer to the thread beginning with > >> http://lists.freebsd.org/pipermail/freebsd-ports/2008-January/046245.html > >> > >> For the temporary solution, > >> edit freebsd-games/files/patch-larn_Makefile to add -fwritable-strings > >> to CFLAGS and do not forget to use gcc34 or earlier instead of gcc in > >> 7.0. > >> > >> Hope this helps. > > > > I believe that someone in DragonFly BSD did a lot of clean up in the > > src/games/*. But I don't know if these cleans up will helping with this > > issue. It might be worth for someone to dig in there and bring in FreeBSD > > if someone care about these games. > > Diff between freebsd-games and DragonFly, after removing irrelevant stuff, > is over a megabyte long. Maybe we should just use their code verbatim? > > (Untested diff at http://freebsd.org/~trasz/patch-zzz_fixes_from_dfly) > Good idea, I tested the games from DragonflyBSD and they seem to work OK on FreeBSD 7/GCC4.2 Everything compiles with some minor changes, the two issues with larn and hack are solved, I didn't test any of the other games yet. I need to do some more cleanup/testing, I will send a PR tomorrow since it's very late now ... Regards, Martin Tournoij