Date: Tue, 10 Apr 2012 12:48:39 -0700 From: Jason Helfman <jgh@FreeBSD.org> To: Olli Hauer <ohauer@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net-mgmt/rancid Makefile distinfo pkg-plist ports/net-mgmt/rancid/files patch-bin-rancid.in patch-bin__control_rancid.in patch-etc::Makefile.am patch-etc::Makefile.in patch-etc__Makefile.am patch-etc__Makefile.in Message-ID: <20120410194839.GB83964@dormouse.experts-exchange.com> In-Reply-To: <201204092207.q39M7Qdp013689@repoman.freebsd.org> References: <201204092207.q39M7Qdp013689@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 09, 2012 at 10:07:26PM +0000, Olli Hauer thus spake: >ohauer 2012-04-09 22:07:26 UTC > > FreeBSD ports repository > > Modified files: > net-mgmt/rancid Makefile distinfo pkg-plist > Added files: > net-mgmt/rancid/files patch-bin__control_rancid.in > patch-etc__Makefile.am > patch-etc__Makefile.in > Removed files: > net-mgmt/rancid/files patch-bin-rancid.in > patch-etc::Makefile.am > patch-etc::Makefile.in > Log: > - update to version 2.3.8 > > Changes: > http://www.shrubbery.net/rancid/CHANGES > > Additional portlint fixes > > PR: 165974 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=165974 > Submitted by: ohauer > Approved by: Mohacsi Janos <janos.mohacsi@bsd.hu> (maintainer) > Feature safe: yes > > Revision Changes Path > 1.32 +5 -5 ports/net-mgmt/rancid/Makefile > 1.12 +2 -2 ports/net-mgmt/rancid/distinfo > 1.2 +0 -13 ports/net-mgmt/rancid/files/patch-bin-rancid.in (dead) > 1.1 +13 -0 ports/net-mgmt/rancid/files/patch-bin__control_rancid.in (new) > 1.4 +0 -34 ports/net-mgmt/rancid/files/patch-etc::Makefile.am (dead) > 1.4 +0 -34 ports/net-mgmt/rancid/files/patch-etc::Makefile.in (dead) > 1.1 +31 -0 ports/net-mgmt/rancid/files/patch-etc__Makefile.am (new) > 1.1 +31 -0 ports/net-mgmt/rancid/files/patch-etc__Makefile.in (new) > 1.14 +3 -0 ports/net-mgmt/rancid/pkg-plist > >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/rancid/Makefile.diff?&r1=1.31&r2=1.32&f=h >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/rancid/distinfo.diff?&r1=1.11&r2=1.12&f=h >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/rancid/files/patch-bin-rancid.in >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/rancid/files/patch-bin__control_rancid.in >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/rancid/files/patch-etc::Makefile.am >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/rancid/files/patch-etc::Makefile.in >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/rancid/files/patch-etc__Makefile.am >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/rancid/files/patch-etc__Makefile.in >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/rancid/pkg-plist.diff?&r1=1.13&r2=1.14&f=h > Can you please look at this pr, as I took it for a rancid update. http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/166585 This port doesn't consider package installation users and clobbers existing configurations. Per the Handbook: If there is a very good reason not to install a working configuration file by default, leave the @exec line out of pkg-plist and add a message pointing out that the user must copy and edit the file before the software will work. Regarding the handbook entry, I don't know if this is the case for this software, but I put the pr into feedback so I could engage the maintainer regarding this, but have not heard anything. Thanks -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120410194839.GB83964>