From owner-cvs-src@FreeBSD.ORG Wed Apr 13 18:00:58 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 734E516A4CF for ; Wed, 13 Apr 2005 18:00:58 +0000 (GMT) Received: from rproxy.gmail.com (rproxy.gmail.com [64.233.170.195]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4D1E243D5E for ; Wed, 13 Apr 2005 18:00:57 +0000 (GMT) (envelope-from avleeuwen@gmail.com) Received: by rproxy.gmail.com with SMTP id j1so205499rnf for ; Wed, 13 Apr 2005 11:00:56 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=K8fmdAatKbbmcVW1cA3owiA4nZotodoTTTLHGBaViQaaFF8vRbPqhLT0BRAD+j1qFqN7/FzLgOVQsm26VJKERjojv2gJswsR8UVqio1GBcuHd9BGPss7XMWiMk1cmc6clcCmVTriD/rCFTfAID4Lja2iJXt8Oim/xBIx5Wc73M4= Received: by 10.38.66.8 with SMTP id o8mr841802rna; Wed, 13 Apr 2005 11:00:50 -0700 (PDT) Received: by 10.38.88.56 with HTTP; Wed, 13 Apr 2005 11:00:49 -0700 (PDT) Message-ID: Date: Wed, 13 Apr 2005 20:00:49 +0200 From: Arjan Van Leeuwen To: Warner Losh In-Reply-To: <200504131630.j3DGUUDu060801@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <200504131630.j3DGUUDu060801@repoman.freebsd.org> cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/pci pcib_if.m X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Arjan Van Leeuwen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2005 18:00:58 -0000 On 4/13/05, Warner Losh wrote: > imp 2005-04-13 16:30:30 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/dev/pci pcib_if.m > Log: > Default to a interrupt router that returns an invalid interrupt. > Otherwise, busses that implement the pcib interface that forget to > implement pcib_route_interrupt would return EIO, which the caller > interprets as 'use interrupt 6'. This is likely the cause of much of > the grief that we had when I enabled power modes for the cardbus > bridge, since the card needed to reroute the interrupt to it and it > was getting 6 which was d by the pccbb sanity checks. >=20 > Revision Changes Path > 1.6 +9 -1 src/sys/dev/pci/pcib_if.m This seems to break my kernel build: awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/dev/sound/pcm/ac97_if.m -c ; cc -c -O2 -pipe -fno-strict-aliasing -march=3Dpentium3 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=3Dc99 -g -nostdinc -I- -I. -I/usr/src/sys -I/usr/src/sys/contrib/dev/acpica -I/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/ipfilter -I/usr/src/sys/contrib/pf -I/usr/src/sys/contrib/dev/ath -I/usr/src/sys/contrib/dev/ath/freebsd -I/usr/src/sys/contrib/ngatm -I/usr/src/sys/dev/twa -D_KERNEL -include opt_global.h -fno-common -finline-limit=3D8000 --param inline-unit-growth=3D100 --param large-function-growth=3D1000 -mno-align-long-strings -mpreferred-stack-boundary=3D2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -ffreestanding -Werror ac97_if.c pcib_if.c: In function `null_route_interrupt': pcib_if.c:24: error: `PCI_INVALID_IRQ' undeclared (first use in this functi= on) pcib_if.c:24: error: (Each undeclared identifier is reported only once pcib_if.c:24: error: for each function it appears in.) pcib_if.c: At top level: pcib_if.c:23: warning: 'null_route_interrupt' defined but not used *** Error code 1 1 error *** Error code 2 1 error *** Error code 2 1 error Arjan