From owner-cvs-sys Fri Jul 12 17:57:53 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id RAA27915 for cvs-sys-outgoing; Fri, 12 Jul 1996 17:57:53 -0700 (PDT) Received: from ref.tfs.com ([206.245.251.1]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id RAA27910; Fri, 12 Jul 1996 17:57:51 -0700 (PDT) Received: (from julian@localhost) by ref.tfs.com (8.7.5/8.7.3) id RAA02771; Fri, 12 Jul 1996 17:57:55 -0700 (PDT) Message-Id: <199607130057.RAA02771@ref.tfs.com> Subject: Re: cvs commit: src/sys/i386/boot/biosboot asm.h start.S To: bde@freefall.freebsd.org (Bruce Evans) Date: Fri, 12 Jul 1996 17:57:55 -0700 (PDT) From: "JULIAN Elischer" Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org In-Reply-To: <199607120542.WAA02603@freefall.freebsd.org> from "Bruce Evans" at Jul 11, 96 10:42:04 pm X-Mailer: ELM [version 2.4 PL25 ME8b] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > > > bde 96/07/11 22:42:03 > > Modified: sys/i386/boot/biosboot asm.h start.S > Log: > Moved the definition of DEBUGMSG() from asm.h to start.S. This macro > is only appropriate to use in the special environment of start.S (real > mode plus some conventions about not saving registers), and asm.h is > supposed to be for generic macros. This is a bad move.. DEBUGMSG is useful right up through quite a bit of boot2.S I used it ito find how far I was getting into boot2.S which is the reason that it was moved to asm.h can you please put it back there!? > > Removed some unnecessary parentheses. > > Revision Changes Path > 1.6 +1 -8 src/sys/i386/boot/biosboot/asm.h > 1.8 +12 -5 src/sys/i386/boot/biosboot/start.S >