From owner-cvs-src@FreeBSD.ORG Thu Aug 4 21:19:33 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 81AEC16A41F for ; Thu, 4 Aug 2005 21:19:33 +0000 (GMT) (envelope-from maksim.yevmenkin@gmail.com) Received: from rproxy.gmail.com (rproxy.gmail.com [64.233.170.193]) by mx1.FreeBSD.org (Postfix) with ESMTP id 810E343D49 for ; Thu, 4 Aug 2005 21:19:32 +0000 (GMT) (envelope-from maksim.yevmenkin@gmail.com) Received: by rproxy.gmail.com with SMTP id i8so418014rne for ; Thu, 04 Aug 2005 14:19:31 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=d6dwFOYUfXRVN3pE27jRzzN5ora0yro/JtdR7ktHRVhsFrkc3XO63YJYaoupvQljYXv6PSZf8eL4nXYXtqwdq47vTEZmK9f4+aB6h4XiQvuzzN0ken2TEpmc6C2LgJfbVSNtHT3kqTJE6ya6YFtxg4qw215IT2iDPczAbp4Yh7M= Received: by 10.38.181.38 with SMTP id d38mr1029099rnf; Thu, 04 Aug 2005 14:19:31 -0700 (PDT) Received: by 10.38.208.5 with HTTP; Thu, 4 Aug 2005 14:19:31 -0700 (PDT) Message-ID: Date: Thu, 4 Aug 2005 14:19:31 -0700 From: Maksim Yevmenkin To: src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org In-Reply-To: <200508042112.j74LCMgu021304@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <200508042112.j74LCMgu021304@repoman.freebsd.org> Cc: Subject: Re: cvs commit: src/sys/dev/an if_an.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Maksim Yevmenkin List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Aug 2005 21:19:33 -0000 On 8/4/05, Maksim Yevmenkin wrote: > emax 2005-08-04 21:12:22 UTC >=20 > FreeBSD src repository >=20 > Modified files: (Branch: RELENG_6) > sys/dev/an if_an.c > Log: > MFC if_an.c v1.69 to RELENG_6 >=20 > Reorganize an_detach() a bit. Make sure ether_ifdetach() and if_free() > are called outside of AN_LOCK()/AN_UNLOCK. This fixes the following > WITNESS warning (produced when an(4) PCMCIA card is detached). > taskqueue_drain with the following non-sleepable locks held: > exclusive sleep mutex an0 (network driver) r =3D 0 (0xc59af168) locked = @ /usr/src/ > sys/dev/an/if_an.c:2836 >=20 > Do not lock an to check gone flag. Only need to hold the lock to set > the gone flag. >=20 > Reviewed by: imp > Approved by: re (kemsmith) Approved by: re (kensmith) please accept my apologies >=20 > Revision Changes Path > 1.67.2.1 +2 -2 src/sys/dev/an/if_an.c >=20 max