Date: Mon, 6 Nov 2017 15:49:10 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: "Tobias C. Berner" <tcberner@gmail.com> Cc: Baptiste Daroussin <bapt@freebsd.org>, Jochen Neumeister <joneum@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r453522 - head/www/tikiwiki Message-ID: <20171106154910.GA80443@FreeBSD.org> In-Reply-To: <CAOshKtdCYDpK9SZW2MDAd%2BQidyhd9OqtgX3q=Zp8X7uz0Zsj5g@mail.gmail.com> References: <201711050811.vA58BimG043763@repo.freebsd.org> <20171105111520.mwcfak3lp2peecpx@ivaldir.net> <CAOshKtdCYDpK9SZW2MDAd%2BQidyhd9OqtgX3q=Zp8X7uz0Zsj5g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 05, 2017 at 12:47:13PM +0100, Tobias C. Berner wrote: > To quote mat@ from > https://lists.freebsd.org/pipermail/svn-ports-all/2017-August/159181.html > > It is explained in the porter's handbook, always use DISTVERSION except > > when there is no version in the distribution file, or when DISTVERSION > > gives an incorrect PORTVERSION. I've seen the quote, but I don't see anything wrong with using PORTVERSION (like we traditionally did) when it is "simple" (that is, identical to the DISTVERSION). It might look "cleaner" in mat@'s eyes to always use (set) DISTVERSION since it is, in fact, closely tied to the *distfile* version, but enforcing this just based on that is a bit too much. Personally I'd prefer that PHB text laxed (and keep using PORTVERSION when it suffices). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171106154910.GA80443>