From owner-freebsd-current@FreeBSD.ORG Wed May 13 19:57:42 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0FC1F1065676; Wed, 13 May 2009 19:57:42 +0000 (UTC) (envelope-from mel.flynn+fbsd.current@mailing.thruhere.net) Received: from mailhub.rachie.is-a-geek.net (rachie.is-a-geek.net [66.230.99.27]) by mx1.freebsd.org (Postfix) with ESMTP id C9D4A8FC0C; Wed, 13 May 2009 19:57:41 +0000 (UTC) (envelope-from mel.flynn+fbsd.current@mailing.thruhere.net) Received: from sarevok.dnr.servegame.org (mailhub.rachie.is-a-geek.net [192.168.2.11]) by mailhub.rachie.is-a-geek.net (Postfix) with ESMTP id 43BE27E83F; Wed, 13 May 2009 11:57:40 -0800 (AKDT) From: Mel Flynn To: freebsd-current@freebsd.org Date: Wed, 13 May 2009 21:57:14 +0200 User-Agent: KMail/1.11.2 (FreeBSD/8.0-CURRENT; KDE/4.2.2; i386; ; ) References: <4A09F850.2080208@freebsd.org> In-Reply-To: <4A09F850.2080208@freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200905132157.14906.mel.flynn+fbsd.current@mailing.thruhere.net> Cc: Tim Kientzle , Dmitry Morozovsky , Garance A Drosehn Subject: Re: newsyslog(8) patch for both size and time checks X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 May 2009 19:57:42 -0000 On Wednesday 13 May 2009 00:29:36 Tim Kientzle wrote: > Garance A Drosehn wrote: > > At 1:59 PM +0400 5/12/09, Dmitry Morozovsky wrote: > >> for now, if log is configured to be rotated in time manner, its size > >> is not checked ... > >> > >> The following simple patch should fix the problem. Any objection to > >> commit this? > > > > It would fix your problem, but it changes the behavior as is explicitly > > documented in 'man newsyslog.conf' . There is a paragraph in the man > > page which makes it clear that if both fields are specified, then the > > log file will only be rotated if both conditions are true. > > I've never liked that paragraph and find the > documented behavior is much less useful than the > proposed behavior. I rotate maillogs on not so busy machines using this functionality. The reasoning behind it is that I keep a limited number of logs available and if for some reason the machine starts spewing a lot of mail, I still want to know when it started. I also don't see the point of compressing/rotating 1-10 lines if the machine only sends out the periodic mails, hence this works peachy. > If compatibility is essential, perhaps we could > add a new flag to control this behavior. (I would > argue for changing the default and providing a flag > to obtain the old behavior.) Fine on the flag, maybe mergemaster could be a little more assisting in this case, since I'm not looking forward to "just adding a flag". Like mergemaster -p could auto-upgrade the lines that have both columns with values? -- Mel