Date: Mon, 15 Aug 2016 21:42:22 -0700 From: Cy Schubert <Cy.Schubert@komquats.com> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Cy Schubert <cy@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r420264 - in head/sysutils/syslog-ng-devel: . files Message-ID: <201608160442.u7G4gMXn069114@slippy.cwsent.com> In-Reply-To: Message from Mathieu Arnold <mat@FreeBSD.org> of "Mon, 15 Aug 2016 22:13:19 %2B0200." <8535CC64B4215AADBFEFB709@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <8535CC64B4215AADBFEFB709@atuin.in.mat.cc>, Mathieu Arnold
writes:
> --==========4917ED3318780F7D673C==========
> Content-Type: text/plain; charset=utf-8
> Content-Transfer-Encoding: quoted-printable
> Content-Disposition: inline
>
>
>
> +--On 15 ao=C3=BBt 2016 20:17:30 +0000 Cy Schubert <cy@FreeBSD.org> wrote:
> | -PORTVERSION=3D 3.8.0b1
> | -PORTREVISION=3D 1
> | +# XXX Should be: PORTVERSION=3D 3.8.0.b2
> | +# XXX update at 3.8.1.
> | +PORTVERSION=3D 3.8.0b2
> | PKGNAMESUFFIX=3D -devel
> | CATEGORIES=3D sysutils
> | +# XXX Should be: DISTVERSION=3D
> | ${PORTVERSION:S/.a/alpha/:S/.b/beta/:S/.r/rc/}
> | +# XXX update at 3.8.1.
> | DISTVERSION=3D ${PORTVERSION:S/a/alpha/:S/b/beta/:S/r/rc/}
>
> To be honest, all this should be:
>
> DISTVERSION=3D 3.8.0beta2
>
> No need to set PORTVERSION. At all.=20
>
> Also, DISTVERSION is set too late, it should be before CATEGORIES and
> PKGNAMESUFFIX.
That sounds like a plan. This would need to be done for 3.8.1beta1 because
if this is done now the port's epoch would need to increase by one because
3.8.0.b2 < 3.8.0b2. I'd like to avoid setting the PORTEPOCH if at all
possible.
--
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org
The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201608160442.u7G4gMXn069114>