From nobody Wed May 27 08:10:05 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gQMjv2nnZz6fcbg for ; Wed, 27 May 2026 08:10:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gQMjt3Bq6z3Pdc for ; Wed, 27 May 2026 08:10:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779869410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ye2tiscLWMUVIx36dgU28S9iyDpFDC7ThUIRVxiq2rE=; b=jGEODMNbJefFd/3NvZbi14s+T6wM60wAB0to5cBnHygNOrkUEwV0a+FOLkyHciJFKYtLJQ F5BP61MvZMoQYjQ2Fci+WL4WG2EHvCitaTSedwZivWsHA/PSmuojxdAwA/gnZCHOjNjrWe IOo3BV0p1+JVBOza4+78BcsYoe4PTuMj9JmZR2aw58MyFqotVg2G761J6WYuwv37XHZjBV vvoJWXDweIHAr9GLvVPazbzOZUvcohwuslOoIu5vO575gra5mw36iKA3sos0I7c1uqzeOC GZyWjhxtJ+gp4TvHscXY6b6+yM8vXXlPKfJpES/lqHgFae8FSmlQjn2AYSMX/Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779869410; a=rsa-sha256; cv=none; b=fO+ATt92MVGAch+E+J8PInItlKuR4fVFfvhscVoUZvLJd6eQTgZhaHrPdSI0z787Ef7XZQ R8jYnh283TpypPRx3HQ711z9cdKWnCyqEXlSqfYYA0OjP6RoGIA1qGBjYxxoAhgPeJ36hC qxO26zWXExtWJl76TVE8WRKr+QWFyFkCWBomVApdXrsXtqHeYAjpyEe4H6ynExmBjHM1sk RIncNl2vxqC+KznxsgFv9Mve2c/cWQWwTJMj/SLYbRUdq4ZQ++gGhc/0pJuh4WkPzndy5V nDrWB25oQuVg9KGVGRNwHOTLwHrbnrFlv84ERQwgyD7ZCgINfX5zGE7kW2fA0w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779869410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ye2tiscLWMUVIx36dgU28S9iyDpFDC7ThUIRVxiq2rE=; b=o5f8rIv3/sTZvVhxtcXn7Q3s26E8p0lr1Xq1oV94jX5JIbC4nAVWLy7XUML72d08XOoqr7 6/HuW74CrzF1dg9ihsqOx4lgyb/cDSmDpibFqdma+AMDSbWBf6pjxoYtTn+CJ3ZnL+5ZB/ 7cRVf+4wp8khTJLcB1xIRQDsTs3UIudvkqR6qobYPNvBWEVudOVmNwM56FQ7NRsvW68uU6 f3mx3+iWA43EKLQ1PYakJUvLdzV2N9mC9XVRW/mJTzWWEBSHuIpG+jJUyeqKA2rVfbHJ+5 vWN5zUQlc4YNsB4xhNRWAuyPcAgY6y0SqFu+CJPVHghw7uF4s5FKxVZeY+UP6Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gQMjt2Lp7zrDX for ; Wed, 27 May 2026 08:10:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 20730 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 27 May 2026 08:10:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Haoxiang Li From: Konstantin Belousov Subject: git: f0e702a7a289 - main - smbfs: plug smbfs_node_alloc() leak of name buffers when insmntque() fails List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f0e702a7a289f0f350bdaeb943805d6d17f9e403 Auto-Submitted: auto-generated Date: Wed, 27 May 2026 08:10:05 +0000 Message-Id: <6a16a6dd.20730.617c5cab@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=f0e702a7a289f0f350bdaeb943805d6d17f9e403 commit f0e702a7a289f0f350bdaeb943805d6d17f9e403 Author: Haoxiang Li AuthorDate: 2026-05-26 13:21:39 +0000 Commit: Konstantin Belousov CommitDate: 2026-05-27 08:09:31 +0000 smbfs: plug smbfs_node_alloc() leak of name buffers when insmntque() fails PR: 295577 MFC after: 2 weeks --- sys/fs/smbfs/smbfs_node.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/fs/smbfs/smbfs_node.c b/sys/fs/smbfs/smbfs_node.c index 9893987f7ccd..b2b5d63e2eaf 100644 --- a/sys/fs/smbfs/smbfs_node.c +++ b/sys/fs/smbfs/smbfs_node.c @@ -212,6 +212,10 @@ smbfs_node_alloc(struct mount *mp, struct vnode *dvp, const char *dirnm, SMBERROR("new vnode '%s' born without parent ?\n", np->n_name); error = insmntque(vp, mp); if (error) { + smbfs_name_free(np->n_name); + free(np->n_rpath, M_SMBNODENAME); + if (np->n_parent != NULL && (np->n_flag & NREFPARENT) != 0) + vrele(np->n_parent); free(np, M_SMBNODE); return (error); }