From owner-svn-src-all@freebsd.org Tue Nov 17 14:11:49 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E56BA2EE044; Tue, 17 Nov 2020 14:11:49 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cb7D43j4xz4jBx; Tue, 17 Nov 2020 14:11:48 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: by mail-ej1-f47.google.com with SMTP id 7so29600657ejm.0; Tue, 17 Nov 2020 06:11:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=sxzQdwICp4u42GIA27NEi9RaRwGGP5hgTc57sdsfeA0=; b=Q1Spj6fiak3ziRWgx2MpiQL0dewQifKBTEoJHFZR2nGgO3CNftqefWC0pou8zdANWv b/C5GP8Yzugt6Ib8pqN/qXxnCAvpmmH2T5GuQFZ4tfmhkK31ssrBfbOjxW7RvHnFpSDQ MuESUbBkzRGyf3iHr09P1el4Zs/ohmsy+ZuFLSl9NG8rXC+kPrrmfFQSEPidmTyKFLeC Ezp58O0Awpt6eWkf5KmtZJn4Yi8ghDnDN8FRwnIZv02bxIXKAHu6M7vDf9lvwNKNfh97 Hzb4ICN3DjuEXNSHMyLYOIzq6f7WytEpijzksYHNBGJOhqGz00LYvZ5WCKoAwCVQofFC jwLQ== X-Gm-Message-State: AOAM5313NjSRdZvIN9iWl2Co1Nz0JiIOXU0xcm30U3vVpJp1j60gZVbQ /iPfHGPAcmY1z46wXg8Rp9mF+PR3w6A= X-Google-Smtp-Source: ABdhPJx9bbA7khE5L3cYPdzdMkTXOrrlZ4W8L0QWNuwPBQX1z9CetdmXwLtogR779ftQLOk2Qoz0Cg== X-Received: by 2002:a17:906:1f86:: with SMTP id t6mr19195864ejr.356.1605622306582; Tue, 17 Nov 2020 06:11:46 -0800 (PST) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com. [209.85.208.41]) by smtp.gmail.com with ESMTPSA id f23sm11917447eds.41.2020.11.17.06.11.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Nov 2020 06:11:46 -0800 (PST) Received: by mail-ed1-f41.google.com with SMTP id q16so7394153edv.10; Tue, 17 Nov 2020 06:11:46 -0800 (PST) X-Received: by 2002:a05:6402:144f:: with SMTP id d15mr21364850edx.300.1605622306191; Tue, 17 Nov 2020 06:11:46 -0800 (PST) MIME-Version: 1.0 References: <202011171407.0AHE7ROZ099170@repo.freebsd.org> In-Reply-To: <202011171407.0AHE7ROZ099170@repo.freebsd.org> From: "Jonathan T. Looney" Date: Tue, 17 Nov 2020 09:11:35 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r367763 - head/cddl/contrib/opensolaris/common/ctf To: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 4Cb7D43j4xz4jBx X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of jonlooney@gmail.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=jonlooney@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; DMARC_NA(0.00)[freebsd.org]; SPAMHAUS_ZRD(0.00)[209.85.218.47:from:127.0.2.255]; RCVD_COUNT_THREE(0.00)[4]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.218.47:from]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCVD_IN_DNSWL_NONE(0.00)[209.85.218.47:from]; FORGED_SENDER(0.30)[jtl@freebsd.org,jonlooney@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.218.47:from]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_NEQ_ENVFROM(0.00)[jtl@freebsd.org,jonlooney@gmail.com]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2020 14:11:50 -0000 On Tue, Nov 17, 2020 at 9:07 AM Jonathan T. Looney wrote: > Author: jtl > Date: Tue Nov 17 14:07:27 2020 > New Revision: 367763 > URL: https://svnweb.freebsd.org/changeset/base/367763 > > Log: > When copying types from one CTF container to another, ensure that we > always copy intrinsic data types before copying bitfields which are > based on those types. This ensures the type ordering in the destination > CTF container matches the assumption made elsewhere in the CTF code > that instrinsic data types will always appear before bitfields based on > those types. > > This resolves the following error message some users have seen after > r366908: > "/usr/lib/dtrace/ipfw.d", line 121: failed to copy type of 'ip6p': > Conflicting type is already defined > > Reviewed by: markj > Sponsored by: Netflix > Differential Revision: https://reviews.freebsd.org/D27213 FWIW, this should also have said: MFC after: 2 weeks