From owner-freebsd-hackers Thu Oct 16 05:43:35 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id FAA25897 for hackers-outgoing; Thu, 16 Oct 1997 05:43:35 -0700 (PDT) (envelope-from owner-freebsd-hackers) Received: from plum.cyber.com.au (plum.cyber.com.au [203.7.155.24]) by hub.freebsd.org (8.8.7/8.8.7) with SMTP id FAA25892 for ; Thu, 16 Oct 1997 05:43:32 -0700 (PDT) (envelope-from darrenr@cyber.com.au) Received: (from darrenr@localhost) by plum.cyber.com.au (8.6.12/8.6.6) id WAA00879; Thu, 16 Oct 1997 22:40:46 +1000 From: Darren Reed Message-Id: <199710161240.WAA00879@plum.cyber.com.au> Subject: Re: Freebsd 3.0 current fails ipfilter 3.2b8 build (fwd) To: julian@whistle.com (Julian Elischer) Date: Thu, 16 Oct 1997 22:40:46 +1000 (EST) Cc: hackers@freebsd.org In-Reply-To: from "Julian Elischer" at Oct 15, 97 11:37:25 pm X-Mailer: ELM [version 2.4 PL23] Content-Type: text Sender: owner-freebsd-hackers@freebsd.org X-Loop: FreeBSD.org Precedence: bulk In some mail I received from Julian Elischer, sie wrote > > > > On Thu, 16 Oct 1997, Darren Reed wrote: > > > In some mail I received from Julian Elischer, sie wrote > > > > > > All the "_var.h" files contain variables who'se scope is within the > > > kernel only. > > > > Yup, I think that's a reasonable approach to take. > > > But these are structures that are not exported, and > which ARE changing. I don't see that as a reason for moving it into if_var.h > > I don't think it should extend, however, to structure definitions. > > > > > The only exception is LKMs which should define KERNEL. > > > I don't know who did this, (I see in the logs it was garrett) > > > but the idea is simply to make it more obvios when you are > > > doing the WRONG thing > > > and including kernel private variables (that are subject to change, > > > and not part of the API) . > > > > There is an API ? > What do you want that struct for? well, ifconfig, netstat, etc. all need it. if you're writing your own LKM for a network driver, you need it. if you're writing firewalling packet filtering code, you need it. "struct ifnet" is used in _lots_ of places. if you want to simulate kernel code, then you also need it.