From owner-freebsd-current@FreeBSD.ORG  Tue Jun  3 04:05:02 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 825A237B401
	for <freebsd-current@freebsd.org>;
	Tue,  3 Jun 2003 04:05:02 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 70ED443FAF
	for <freebsd-current@freebsd.org>;
	Tue,  3 Jun 2003 04:05:01 -0700 (PDT)	(envelope-from bde@zeta.org.au)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id VAA29909;
	Tue, 3 Jun 2003 21:04:53 +1000
Date: Tue, 3 Jun 2003 21:04:52 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Jun Kuriyama <kuriyama@imgsrc.co.jp>
In-Reply-To: <7mel2bddub.wl@black.imgsrc.co.jp>
Message-ID: <20030603205030.E19084@gamplex.bde.org>
References: <7mvfvpcb8s.wl@black.imgsrc.co.jp>
	<20030602194516.Q15091@gamplex.bde.org>
	<7mel2bddub.wl@black.imgsrc.co.jp>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: Current <freebsd-current@freebsd.org>
Subject: Re: Remove absolute symlink in $MAKEOBJDIR
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Jun 2003 11:05:02 -0000

On Tue, 3 Jun 2003, Jun Kuriyama wrote:

> At Mon, 2 Jun 2003 10:10:26 +0000 (UTC),
> Bruce Evans wrote:
>
> > > (2) Use correct dependency in sys/boot/i386/kgzldr.
> >
> > This is too hackish for me.  Try using the same method as for lib/csu.
> > I think you nmainly care about "make install" building things.  This is
> > from longstanding brokenness of installation of man pages which was
> > cloned to brokenness of installation of FILES.
>
> Hmm, like this?  I don't know which owner and mode should be used at
> realinstall stage.

Same as for csu (LIBOWN/LIBGRP/LIBMODE/LIBDIR).  BINDIR should have been
set to LIBDIR; LIBDIR can be used directly now the install rule is explicit.

> Index: Makefile
> ===================================================================
> RCS file: /home/ncvs/src/sys/boot/i386/kgzldr/Makefile,v
> retrieving revision 1.12
> diff -u -r1.12 Makefile
> --- Makefile	30 Sep 2002 20:37:57 -0000	1.12
> +++ Makefile	3 Jun 2003 03:41:02 -0000
> @@ -1,6 +1,5 @@
>  # $FreeBSD: src/sys/boot/i386/kgzldr/Makefile,v 1.12 2002/09/30 20:37:57 peter Exp $
>
> -FILES=	kgzldr.o
>  SRCS=	start.s boot.c inflate.c lib.c crt.s sio.s
>  OBJS=	${SRCS:N*.h:R:S/$/.o/g}
>  CFLAGS=	-ffreestanding
> @@ -15,7 +14,13 @@
>  BOOT_COMCONSOLE_PORT?=	0x3f8
>  AFLAGS+=--defsym SIO_PRT=${BOOT_COMCONSOLE_PORT}
>
> +all: ${OBJS} kgzldr.o
> +

CLEANFILES needs to be adjusted too.

>  kgzldr.o: ${OBJS}
>  	${CC} ${LDFLAGS} -o ${.TARGET} ${OBJS}
> +
> +realinstall:
> +	${INSTALL} -o ${BINOWN} -g ${BINGRP} -m ${LIBMODE} \
> +		kgzldr.o ${DESTDIR}${BINDIR}

The continuation indent should be 4 as in csu/*/Makefile (except for the
zombie i386 (aout) Makefile).

>
>  .include <bsd.prog.mk>

I think it should include <bsd.lib.mk>.

Bruce