From owner-svn-src-all@freebsd.org Mon Jun 15 11:02:02 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0ABF132F75B; Mon, 15 Jun 2020 11:02:02 +0000 (UTC) (envelope-from yuripv@yuripv.dev) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49lpLd4JDsz4QsS; Mon, 15 Jun 2020 11:02:01 +0000 (UTC) (envelope-from yuripv@yuripv.dev) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id AEEC85C00D8; Mon, 15 Jun 2020 07:02:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 15 Jun 2020 07:02:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuripv.dev; h= subject:to:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm1; bh=e +UxwaJ6zUy/sYysZaWGxJf1TdwIGwlf1rdGfMI0PDU=; b=E6ZAGDalHLUY87r1g DvMKt4kHAsm1pSDggS7zr6twEs5e0+yuDMzcsOoQ5rp7NmGRE9Pcxh84KkivleIA HTZvPbmJIzBI3sIHNKsZ3vQe+vLPlaV/2jYUx/MBqluz+9OdaZzn7R6zNya8Vz+r 0PKAznxyGb7veoxemuKSqCW1OsEh5CbIQjyd76E1rJdBiBrcvt1nQ8GE37Y7cWjo l+zstPUFIKgp2Vo6YRxxe14XjG+PilgkazbLS36Ncdf/9U8tmCs0YrMZaa8Ziyg+ GtMCFfDJ5jie6WSBb78EYYBtH6H/AJL+oMwyCGdTuJ0sGE+CwtIZLkti9fcPxrjt 3ODWw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=e+UxwaJ6zUy/sYysZaWGxJf1TdwIGwlf1rdGfMI0P DU=; b=Q6xpSVgFkgbenmLr7uErKLtrZG4oRvhSG7hNNLgnBr95h1lKDU9RGlyuz m88t52BV+NkUpDhuVh+D+zOdnHyU7lc5XqLvTqJ1l8kcbagEvQYOaASE5lC1KVEe RysEU37bYU7qxVr/nUj3FLVSHJfdzkM5nnYiGJxR6uBOYgW30bDHAvlzk/MDq/IA /lbmk7XFwQK03aK61TywRzLHxPeBpkRfIVYEW+K+uPY1QYQ3SGxUYbHZoRjT9/r2 QFudyQI74it5fXZhBa5w2T4Ny3J4i6wS1HoxU/6z+EmmHORYIVOF9BC1obend7hQ zcxx3HRn4yzfeHcqCwzNL7AO+Fo3A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudeikedgfeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefuvfhfhffkffgfgggjtgfgsehtke ertddtfeejnecuhfhrohhmpegjuhhrihcurfgrnhhkohhvuceohihurhhiphhvseihuhhr ihhpvhdruggvvheqnecuggftrfgrthhtvghrnhepveefvefgtefgueekfeejudeukeffje eugfeiteetueelvddttefhleehvdejteevnecuffhomhgrihhnpehfrhgvvggsshgurdho rhhgnecukfhppeeluddrvdegtddruddvgedrudefjeenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeihuhhrihhpvheshihurhhiphhvrdguvghv X-ME-Proxy: Received: from [192.168.1.6] (unknown [91.240.124.137]) by mail.messagingengine.com (Postfix) with ESMTPA id 9C6E5328005D; Mon, 15 Jun 2020 07:01:59 -0400 (EDT) Subject: Re: svn commit: r362191 - head/sbin/md5 To: =?UTF-8?Q?Fernando_Apestegu=c3=ada?= , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202006151008.05FA82YG031030@repo.freebsd.org> From: Yuri Pankov Message-ID: <8d50454e-4cec-d665-92ab-e62ca87e68d8@yuripv.dev> Date: Mon, 15 Jun 2020 14:01:59 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <202006151008.05FA82YG031030@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 49lpLd4JDsz4QsS X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:11403, ipnet:66.111.4.0/24, country:US]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2020 11:02:02 -0000 Fernando Apesteguía wrote: > Author: fernape (ports committer) > Date: Mon Jun 15 10:08:02 2020 > New Revision: 362191 > URL: https://svnweb.freebsd.org/changeset/base/362191 > > Log: > md5(1): fix style in man page > > Fix a bunch of style problems reported by mandoc(1) and igor: > > mandoc: ./md5.1:19:71: STYLE: no blank before trailing delimiter: Nm ... rmd160, > mandoc: ./md5.1:20:23: STYLE: no blank before trailing delimiter: Nm ... skein512, > mandoc: ./md5.1:33:2: STYLE: useless macro: Tn > mandoc: ./md5.1:33:2: STYLE: useless macro: Tn > mandoc: ./md5.1:33:2: STYLE: useless macro: Tn > mandoc: ./md5.1:33:2: STYLE: useless macro: Tn > mandoc: ./md5.1:35:2: STYLE: useless macro: Tn > mandoc: ./md5.1:42:2: STYLE: useless macro: Tn > mandoc: ./md5.1:45:2: STYLE: useless macro: Tn > mandoc: ./md5.1:47:2: STYLE: useless macro: Tn > mandoc: ./md5.1:56:2: STYLE: useless macro: Tn > mandoc: ./md5.1:58:2: STYLE: useless macro: Tn > mandoc: ./md5.1:61:2: STYLE: useless macro: Tn > mandoc: ./md5.1:66:2: STYLE: useless macro: Tn > mandoc: ./md5.1:68:2: STYLE: useless macro: Tn > mandoc: ./md5.1:104:24: STYLE: no blank before trailing delimiter: Nm skein512, > mandoc: ./md5.1:117:6: STYLE: referenced manual not found: Xr sha224 3 > > igor: > md5.1:46:no comma after "i.e.":either algorithm, [i.e.] to find an input that produces a specific > > Approved by: bcr@ > Differential Revision: https://reviews.freebsd.org/D25277 > > Modified: > head/sbin/md5/md5.1 > > Modified: head/sbin/md5/md5.1 > ============================================================================== > --- head/sbin/md5/md5.1 Mon Jun 15 03:10:53 2020 (r362190) > +++ head/sbin/md5/md5.1 Mon Jun 15 10:08:02 2020 (r362191) > @@ -1,5 +1,5 @@ > .\" $FreeBSD$ > -.Dd July 9, 2018 > +.Dd June 15, 2020 > .Dt MD5 1 > .Os > .Sh NAME > @@ -16,8 +16,8 @@ > (All other hashes have the same options and usage.) > .Sh DESCRIPTION > The > -.Nm md5 , sha1 , sha224 , sha256 , sha384 , sha512, sha512t256, rmd160, > -.Nm skein256, skein512, > +.Nm md5 , sha1 , sha224 , sha256 , sha384 , sha512 , sha512t256 , rmd160 , > +.Nm skein256 , skein512 , > and > .Nm skein1024 > utilities take as input a message of arbitrary length and produce as > @@ -29,43 +29,29 @@ of the input. > It is conjectured that it is computationally infeasible to > produce two messages having the same message digest, or to produce any > message having a given prespecified target message digest. > -The > -.Tn SHA-224 , SHA-256 , SHA-384 , SHA-512, RIPEMD-160, > -and > -.Tn SKEIN > +The SHA-224 , SHA-256 , SHA-384 , SHA-512, RIPEMD-160, > +and SKEIN > algorithms are intended for digital signature applications, where a > large file must be > .Dq compressed > in a secure manner before being encrypted with a private > (secret) > -key under a public-key cryptosystem such as > -.Tn RSA . > +key under a public-key cryptosystem such as RSA. > .Pp > -The > -.Tn MD5 > -and > -.Tn SHA-1 > -algorithms have been proven to be vulnerable to practical collision > -attacks and should not be relied upon to produce unique outputs, > +The MD5 and SHA-1 algorithms have been proven to be vulnerable to practical > +collision attacks and should not be relied upon to produce unique outputs, > .Em nor should they be used as part of a cryptographic signature scheme. > As of 2017-03-02, there is no publicly known method to > .Em reverse > -either algorithm, i.e. to find an input that produces a specific > +either algorithm, i.e., to find an input that produces a specific > output. > .Pp > -.Tn SHA-512t256 > -is a version of > -.Tn SHA-512 > -truncated to only 256 bits. > -On 64-bit hardware, this algorithm is approximately 50% faster than > -.Tn SHA-256 > -but with the same level of security. > +SHA-512t256 is a version of SHA-512 truncated to only 256 bits. > +On 64-bit hardware, this algorithm is approximately 50% faster than SHA-256 but > +with the same level of security. > The hashes are not interchangeable. > .Pp > -It is recommended that all new applications use > -.Tn SHA-512 > -or > -.Tn SKEIN-512 > +It is recommended that all new applications use SHA-512 or SKEIN-512 > instead of one of the other hash functions. > .Pp > The following options may be used in any combination and must > @@ -101,7 +87,7 @@ Run a built-in test script. > .Sh EXIT STATUS > The > .Nm md5 , sha1 , sha224 , sha256 , sha512 , sha512t256 , rmd160 , > -.Nm skein256 , skein512, > +.Nm skein256 , skein512 , > and > .Nm skein1024 > utilities exit 0 on success, > @@ -114,7 +100,6 @@ option. > .Xr md5 3 , > .Xr ripemd 3 , > .Xr sha 3 , > -.Xr sha224 3 , > .Xr sha256 3 , > .Xr sha384 3 , > .Xr sha512 3 , I think we should create sha256.3 -> sha224.3 instead of removing the reference, as done for sha512.3 -> sha384.3 -- if you look at the sha256.3 man page, it documents all of the SHA224_* functions; i.e.,: Index: Makefile =================================================================== --- Makefile (revision 362145) +++ Makefile (working copy) @@ -40,7 +40,7 @@ MLINKS+=sha256.3 SHA224_Init.3 sha256.3 SHA224_Update.3 MLINKS+=sha256.3 SHA224_Final.3 sha256.3 SHA224_End.3 MLINKS+=sha256.3 SHA224_File.3 sha256.3 SHA224_FileChunk.3 -MLINKS+=sha256.3 SHA224_Data.3 +MLINKS+=sha256.3 SHA224_Data.3 sha256.3 sha224.3 MLINKS+=sha256.3 SHA256_Init.3 sha256.3 SHA256_Update.3 MLINKS+=sha256.3 SHA256_Final.3 sha256.3 SHA256_End.3 MLINKS+=sha256.3 SHA256_File.3 sha256.3 SHA256_FileChunk.3