From owner-cvs-src@FreeBSD.ORG Fri Dec 31 15:39:38 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C242D16A4CE; Fri, 31 Dec 2004 15:39:38 +0000 (GMT) Received: from david.siemens.de (david.siemens.de [192.35.17.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id AC73B43D41; Fri, 31 Dec 2004 15:39:37 +0000 (GMT) (envelope-from andre.albsmeier@siemens.com) Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by david.siemens.de (8.12.6/8.12.6) with ESMTP id iBVFdYtr019727; Fri, 31 Dec 2004 16:39:34 +0100 Received: from mars.cert.siemens.com (mars.cert.siemens.com [139.25.19.9]) by mail2.siemens.de (8.12.6/8.12.6) with ESMTP id iBVFdY3r017097; Fri, 31 Dec 2004 16:39:34 +0100 Received: from curry.mchp.siemens.de (curry.mchp.siemens.de [139.25.42.7]) mail/cert.mc.pre,v 1.65 2004/10/29 21:53:46 mailadm Exp $) with ESMTP id iBVFdYN1070331; Fri, 31 Dec 2004 16:39:34 +0100 (CET) Received: (from localhost) by curry.mchp.siemens.de (8.13.1/8.13.1) id iBVFdYKx041449; Date: Fri, 31 Dec 2004 16:39:34 +0100 From: Andre Albsmeier To: Maxime Henrion Message-ID: <20041231153934.GA78726@curry.mchp.siemens.de> References: <200412282249.iBSMnOlJ061931@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200412282249.iBSMnOlJ061931@repoman.freebsd.org> X-Echelon: SWAT, 777, NCSA, Secure, USCODE X-Advice: Drop that crappy M$-Outlook, I'm tired of your viruses! User-Agent: Mutt/1.5.6i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Andre.Albsmeier@siemens.com cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Dec 2004 15:39:38 -0000 This broke my two 10MBit Intel NICs... On Tue, 28-Dec-2004 at 22:49:24 +0000, Maxime Henrion wrote: > mux 2004-12-28 22:49:24 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_4) > sys/dev/fxp if_fxp.c > Log: > Merge if_fxp.c:1.220 from HEAD to RELENG_4: > > date: 2004/12/20 10:18:21; author: mux; state: Exp; lines: +2 -2 > Only try to use the 82503 serial interface for the 82557 chipsets. The > datasheet says it is only valid for such chipsets and shouldn't be used > with others. This fixes some 82559 based cards which otherwise only > work at 10Mbit. > > MFC after: 5 days > Tested by: krion > > Revision Changes Path > 1.110.2.35 +2 -2 src/sys/dev/fxp/if_fxp.c This one works (100MBit): fxp0: port 0xd000-0xd03f mem 0xe1000000-0xe101ffff,0xe1800000-0xe1800fff irq 12 at device 10.0 on pci0 fxp0: Ethernet address 00:02:b3:1f:25:dc inphy0: on miibus0 inphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto The first broken one: fxp1: port 0xb800-0xb81f mem 0xe0800000-0xe08fffff,0xe3800000-0xe3800fff irq 10 at device 11.0 on pci0 fxp1: Ethernet address 00:a0:c9:a9:1d:06 fxp1: MII without any PHY! device_probe_and_attach: fxp1 attach returned 6 The other broken one (It got named fxp1 as well -- probably because the first one couldn't be attached before) fxp1: port 0xb400-0xb41f mem 0xe0000000-0xe00fffff,0xe2800000-0xe2800fff irq 11 at device 12.0 on pci0 fxp1: Ethernet address 00:a0:c9:a9:1d:23 fxp1: MII without any PHY! device_probe_and_attach: fxp1 attach returned 6 They have an INTEL S82557 and a SEEQ NQ80C24 chip on them. I could make them work again with this patch: --- if_fxp.c.ORI Fri Dec 31 12:03:42 2004 +++ if_fxp.c Fri Dec 31 15:24:01 2004 @@ -511,7 +511,7 @@ * Determine whether we must use the 503 serial interface. */ fxp_read_eeprom(sc, &data, 6, 1); - if (sc->revision == FXP_REV_82557 && (data & FXP_PHY_DEVICE_MASK) != 0 + if ((sc->revision == 0 || sc->revision == FXP_REV_82557) && (data & FXP_PHY_DEVICE_MASK) != 0 && (data & FXP_PHY_SERIAL_ONLY)) sc->flags |= FXP_FLAG_SERIAL_MEDIA; Hope this gets fixed properly. If you want diagnostics data, tell me. -Andre