From nobody Mon Jan 12 17:59:53 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dqgBd43XFz6NtbQ for ; Mon, 12 Jan 2026 17:59:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dqgBd1RkTz3H73 for ; Mon, 12 Jan 2026 17:59:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768240793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=g+V0U4BBbk/sVGsgZ0wY15I1+MnN1eAviYBnLXcMfpI=; b=THDcmkL1FmzKT+VCw6lsYwV7WS3HPTzOWEWlhXgti1Dne5PuQF+ERTrvqNfpiDqD6NIF45 tdGKCAFqMsoKg3/QAWn2cFJqg688Gkx/8cQ3TUPerTlT//jjRtmY6Jb+wHHGrU3wUpLQsy GYU9/3yirg4VHlEVeUQTGkyo0LoQSJWmW0Lb3unBHuQ7mhORQUrxWHQugEWCyqnvEcOqj5 4iAkxDhudZCaIxsH+S6QBhiTM2swfEV3i7fp0H0FyxoPU2YJuhQz2Q8O4sGzEM2QgoHb3f wStcUe6YMdrKECDV+zRZQqVpEB7901ALvoEWAyms1XFxl2bh7CwY2SDW8ep/Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768240793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=g+V0U4BBbk/sVGsgZ0wY15I1+MnN1eAviYBnLXcMfpI=; b=P/7tv7Lk+T+Cgq5qj6pCGS1XTdGk3/2tJXOwgeppHldMnwmpuUkAPJaOou7/yGLxLG/VlH 8xMk4uFJT0ZuUugJqgVnpNVjHqIwn6DkK544Zfqziq1l/DriVHCpDejQ9PUM4+V5KNIUBG 4np6D6O3VjuMtPmquojITkC3xJrM/LVpM05PGdFdOA7LY23VmyXHGw4aQKpy6Fg0NAGGAz Cd/B1cU46FeSix3gLYaG2UMwMGe5bXd33ckTWhLJbqp+VTmp2Di1fudog+z676kS2pkJG8 WlVMSJYBgF5PmgLcL1sLAb+PV8Slkm3I9UtZk59hkEeMVg6gY20bnP05PViYIA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768240793; a=rsa-sha256; cv=none; b=V+nKms+QmDm7nquJVQ4P/wDkn0yLJfbVxVYUyoM24EYyrIDWXewa4zkFv1cjGWm/KzbYEr zivls6RRgPkORrrOoQ8lpZ8u3w1lk4nbYgN8wN+VmFOMW5lYo4L/5Y+EFPpt2o3zHP6e8v NhdMTHnblm8UjW2NKIC2ihx/+hBsYPtnqcdxmg3FvVn9PN2TUgw8CubzJge1et+qEs/q4n nDGU4tLTv5X9NhDpnIvAshiWesq91jxcYOMK6fU6Ukhg7qbAx3YWzYFNSynVf1aJRzXhzI qADqd7Pbw1wsY4BQpFnKri1YNidczRQa5w+lgzVyvsvMsPZ18VAYrBKPU+WOfA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dqgBd0cSbzctF for ; Mon, 12 Jan 2026 17:59:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3b590 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 12 Jan 2026 17:59:53 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: 0e80562f15e3 - stable/14 - zfs: emit .note.GNU-stack section for all ELF targets List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 0e80562f15e3a634a2039cd88784957cb0f682c3 Auto-Submitted: auto-generated Date: Mon, 12 Jan 2026 17:59:53 +0000 Message-Id: <69653699.3b590.6233e904@gitrepo.freebsd.org> The branch stable/14 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=0e80562f15e3a634a2039cd88784957cb0f682c3 commit 0e80562f15e3a634a2039cd88784957cb0f682c3 Author: Dimitry Andric AuthorDate: 2026-01-08 08:35:13 +0000 Commit: Dimitry Andric CommitDate: 2026-01-12 17:59:04 +0000 zfs: emit .note.GNU-stack section for all ELF targets On FreeBSD, linking the zfs kernel module with binutils ld 2.44 shows the following warning: ld: warning: aesni-gcm-avx2-vaes.o: missing .note.GNU-stack section implies executable stack ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker Some of the `.S` files under `module/icp/asm-x86_64/modes` check whether to emit the `.note.GNU-stack` section using: #if defined(__linux__) && defined(__ELF__) We could add `&& defined(__FreeBSD__)` to the test, but since all other `.S` files in the OpenZFS tree use: #ifdef __ELF__ it would seem more logical to use that instead. Any recent ELF platform should support these note sections by now. Reviewed by: emaste, kib, imp MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D54578 (cherry picked from commit eb1b6ec7a79aff05f5f10e1d6b1c63a0d8dc5f2f) --- sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S | 2 +- sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S index cb75043a49a7..a164526a04ff 100644 --- a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S +++ b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S @@ -1274,7 +1274,7 @@ SECTION_STATIC #endif /* Mark the stack non-executable. */ -#if defined(__linux__) && defined(__ELF__) +#ifdef __ELF__ .section .note.GNU-stack,"",%progbits #endif diff --git a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S index f62e056d4b64..06dbf43d407d 100644 --- a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S +++ b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S @@ -713,7 +713,7 @@ SET_OBJ(.Lrem_8bit) .balign 64 /* Mark the stack non-executable. */ -#if defined(__linux__) && defined(__ELF__) +#ifdef __ELF__ .section .note.GNU-stack,"",%progbits #endif