From owner-svn-src-head@FreeBSD.ORG  Thu Apr 11 08:49:12 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 82A525C7;
 Thu, 11 Apr 2013 08:49:12 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail05.syd.optusnet.com.au (mail05.syd.optusnet.com.au
 [211.29.132.186])
 by mx1.freebsd.org (Postfix) with ESMTP id 00349B1F;
 Thu, 11 Apr 2013 08:49:11 +0000 (UTC)
Received: from c211-30-173-106.carlnfd1.nsw.optusnet.com.au
 (c211-30-173-106.carlnfd1.nsw.optusnet.com.au [211.30.173.106])
 by mail05.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id r3B8n226002839
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Thu, 11 Apr 2013 18:49:03 +1000
Date: Thu, 11 Apr 2013 18:49:02 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Gleb Smirnoff <glebius@FreeBSD.org>
Subject: Re: svn commit: r249355 - head/lib/libkvm
In-Reply-To: <20130411082457.GS76816@FreeBSD.org>
Message-ID: <20130411184049.W1641@besplex.bde.org>
References: <201304110730.r3B7Uo6d067302@svn.freebsd.org>
 <20130411175308.Q1435@besplex.bde.org> <20130411082457.GS76816@FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.0 cv=S7iBW/QP c=1 sm=1 a=YIxocstYFt4A:10
 a=kj9zAlcOel0A:10 a=PO7r1zJSAAAA:8 a=JzwRw_2MAAAA:8 a=RPTfz7_hRNcA:10
 a=k2ckYh4kuC5l7K2a6UQA:9 a=CjuIK1q_8ugA:10 a=TEtd8y5WR3g2ypngnwZWYw==:117
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org, Bruce Evans <brde@optusnet.com.au>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Apr 2013 08:49:12 -0000

On Thu, 11 Apr 2013, Gleb Smirnoff wrote:

> On Thu, Apr 11, 2013 at 05:59:24PM +1000, Bruce Evans wrote:
> B> > Modified:
> B> >  head/lib/libkvm/kvm.h
> B> >
> B> > Modified: head/lib/libkvm/kvm.h
> B> > ==============================================================================
> B> > --- head/lib/libkvm/kvm.h	Thu Apr 11 07:02:27 2013	(r249354)
> B> > +++ head/lib/libkvm/kvm.h	Thu Apr 11 07:30:49 2013	(r249355)
> B> > @@ -34,7 +34,7 @@
> B> > #define	_KVM_H_
> B> >
> B> > #include <sys/cdefs.h>
> B> > -#include <sys/_types.h>
> B>
> B> The __uintXX_t types are declared here, and should be used, like the
> B> __Xsize_t types already are.
>
> Why non-standard types should be used instead of standard ones?

Sometimes because the namespace doesn't allow the standard ones, but
here I was just saying to typedef just the standard ones that you need
(only uint64_t?) as is done for size_t and ssize_t.  Including
<sys/types.h> also turns the careful ifdefs for the latter into
no-ops.

Bruce