Date: Sat, 13 Oct 2007 09:37:15 +0530 From: Joseph Koshy <jkoshy@FreeBSD.org> To: Alfred Perlstein <alfred@freebsd.org> Cc: jkoshy@freebsd.org, smp@freebsd.org Subject: Re: hwpmc dealing with sparse cpu systems. Message-ID: <86k5prac98.wl%koshy@unixconsulting.co.in> In-Reply-To: <20071012200006.GK31826@elvis.mu.org> References: <20071012200006.GK31826@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> One of the engineers here seems to have found a bug in the > hwpmc_mod.c module. The problem we have is that cpuids can be > greater than mp_ncpus due to sparseness. > Does the fix here make sense? (replace mp_ncpus with MAXCPU) No, a simple global substitution would probably be incorrect because it would allow userland to get hwpmc to attempt operations on non-existent CPUs. I will look into this. Regards, Koshy <jkoshy@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86k5prac98.wl%koshy>