From owner-svn-ports-all@FreeBSD.ORG Mon May 26 23:15:25 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 661EE2FF; Mon, 26 May 2014 23:15:25 +0000 (UTC) Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66]) by mx1.freebsd.org (Postfix) with ESMTP id F0E982564; Mon, 26 May 2014 23:15:24 +0000 (UTC) Received: from tuna.dhcp.nue.suse.com (nat.nue.novell.com [195.135.221.2]) by ainaz.pair.com (Postfix) with ESMTPSA id 8DAC23F40F; Mon, 26 May 2014 19:06:31 -0400 (EDT) Date: Tue, 27 May 2014 01:06:30 +0200 (CEST) From: Gerald Pfeifer To: Baptiste Daroussin Subject: Re: svn commit: r355454 - head/lang/gcc410 In-Reply-To: <20140526211922.GD20327@ivaldir.etoilebsd.net> Message-ID: References: <201405262111.s4QLBdiW073907@svn.freebsd.org> <20140526211922.GD20327@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Gerald Pfeifer , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 May 2014 23:15:25 -0000 On Mon, 26 May 2014, Baptiste Daroussin wrote: >> +.if exists(/usr/bin/clang) && ${ARCH} == "amd64" >> +USE_GCC= yes >> +.endif > ARCH is only defined after bsd.port.options.mk or bsd.port.pre.mk Good catch, Baptiste! Why does the fix still work then, though? (Before the patch my builds on 10.0/amd64 failed, now they work.) I'm not arguing (testing a fix right now), just trying to understand this properly. If the condition is invald (because ${ARCH} is not set), shouldn't the if-statement default to false? Gerald