From owner-freebsd-bugs@FreeBSD.ORG  Mon Nov 13 11:20:58 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7868A16A412
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 13 Nov 2006 11:20:58 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F2F6E43DE8
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 13 Nov 2006 11:20:11 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id kADBKBEB095281
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 13 Nov 2006 11:20:11 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id kADBKBqo095280;
	Mon, 13 Nov 2006 11:20:11 GMT (envelope-from gnats)
Date: Mon, 13 Nov 2006 11:20:11 GMT
Message-Id: <200611131120.kADBKBqo095280@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Ruslan Ermilov <ru@FreeBSD.org>
Cc: 
Subject: Re: conf/105465: rc.d/nfslocking is dependent on rpcbind
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Ruslan Ermilov <ru@FreeBSD.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Nov 2006 11:20:58 -0000

The following reply was made to PR conf/105465; it has been noted by GNATS.

From: Ruslan Ermilov <ru@FreeBSD.org>
To: Daniel Gerzo <danger@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: conf/105465: rc.d/nfslocking is dependent on rpcbind
Date: Mon, 13 Nov 2006 14:17:59 +0300

 On Mon, Nov 13, 2006 at 10:31:20AM +0100, Daniel Gerzo wrote:
 > Modification of rc.d/nfslocking will be needed as well as update of NFS
 > Handbook chapter (I can take care of the latter one).
 > 
 I'm not sure what updates are needed for the Handbook (probably none),
 but the changes to the script should be like this:
 
 %%%
 Index: nfslocking
 ===================================================================
 RCS file: /home/ncvs/src/etc/rc.d/nfslocking,v
 retrieving revision 1.11
 diff -u -p -r1.11 nfslocking
 --- nfslocking	7 Oct 2004 13:55:26 -0000	1.11
 +++ nfslocking	13 Nov 2006 11:07:37 -0000
 @@ -5,7 +5,7 @@
  #
  
  # PROVIDE: nfslocking
 -# REQUIRE: nfsserver nfsclient nfsd
 +# REQUIRE: nfsserver nfsclient nfsd rpcbind
  # BEFORE:  DAEMON
  # KEYWORD: nojail
  
 @@ -14,13 +14,28 @@
  # Save the (one) commandline argument in case it gets clobbered.
  arg=$1
  
 +start_precmd="nfslocking_precmd"
 +
  # Either NFS client or server must be enabled or this must be a 'forcestart'
  # for either of the daemons to start.
  #
 -start_precmd='checkyesno nfs_server_enable || checkyesno nfs_client_enable ||
 +nfslocking_precmd()
 +{
 +	if ! checkyesno nfs_server_enable && ! checkyesno nfs_client_enable && \
 +	    [ -z "$rc_force" ]
 +	then
 +		return 1
 +	fi
 +	if ! checkyesno rpcbind_enable && \
 +	    ! /etc/rc.d/rpcbind forcestatus 1>/dev/null 2>&1
 +	then
 +		force_depend rpcbind || return 1
 +	fi
 +}
 +
 +stop_precmd='checkyesno nfs_server_enable || checkyesno nfs_client_enable ||
      [ -n "$rc_force" ]'
 -stop_precmd=$start_precmd
 -status_precmd=$start_precmd
 +status_precmd=$stop_precmd
  
  # rpc.statd
  #
 %%%
 
 
 Cheers,
 -- 
 Ruslan Ermilov
 ru@FreeBSD.org
 FreeBSD committer