From owner-cvs-src@FreeBSD.ORG Wed May 23 19:08:44 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5882916A46D; Wed, 23 May 2007 19:08:44 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by mx1.freebsd.org (Postfix) with ESMTP id C181B13C48A; Wed, 23 May 2007 19:08:43 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by core.fnop.net (Postfix) with ESMTP id 9EA386907BB; Wed, 23 May 2007 20:07:34 +0100 (WEST) Received: by core.fnop.net (Postfix, from userid 1015) id 65BFD690A24; Wed, 23 May 2007 20:07:34 +0100 (WEST) X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on core.fnop.net X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=AWL, BAYES_00, FORGED_RCVD_HELO, RCVD_IN_NJABL_DUL,RCVD_IN_SORBS_DUL autolearn=no version=3.1.7 Received: from epsilon.local.fnop.net (87-196-151-62.net.novis.pt [87.196.151.62]) by core.fnop.net (Postfix) with ESMTP id D05FD6907BB; Wed, 23 May 2007 20:07:32 +0100 (WEST) Date: Wed, 23 May 2007 20:07:56 +0100 Message-ID: <86abvvs6ib.wl%rpaulo@fnop.net> From: Rui Paulo To: Andrew Gallatin In-Reply-To: <18004.36709.708317.994071@grasshopper.cs.duke.edu> References: <200705231531.l4NFV12H058289@repoman.freebsd.org> <86bqgbs8kt.wl%rpaulo@fnop.net> <18004.36709.708317.994071@grasshopper.cs.duke.edu> User-Agent: Wanderlust/2.15.5 (Almost Unreal) Emacs/21.3 Mule/5.0 (SAKAKI) X-cite-me: rpaulo MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: ClamAV using ClamSMTP Cc: Rui Paulo , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/pci pci_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2007 19:08:44 -0000 At Wed, 23 May 2007 15:00:30 -0400 (EDT), Andrew Gallatin wrote: > > > Rui Paulo writes: > > At Wed, 23 May 2007 15:31:01 +0000 (UTC), > > Andrew Gallatin wrote: > > > > > > gallatin 2007-05-23 15:31:01 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/pci pci_pci.c > > > Log: > > > Fix a typo in pcib_alloc_msi{x} which resulted in the > > > device's, not the bridge's, softc to be used to check the > > > PCIB_DISABLE_MSI flag. This resulted in randomly allowing > > > or denying MSI interrupts based on whatever value the driver > > > happened to store at sizeof(device_t) bytes into its softc. > > > > > > I noticed this when I stopped getting MSI interrupts > > > after slighly re-arranging mxge's softc yesterday. > > > > Wow, I'll have to try this out on msk(4).. > > To be clear, pci_alloc_msi() was failing, so MSI was not > used at all. It didn't affect the actual generation > of interrupts once MSI is enabled.. Oh, ok. Thanks for the explanation. -- Rui Paulo