From owner-freebsd-acpi@FreeBSD.ORG  Tue Apr 19 21:42:18 2011
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@freebsd.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id E63151065670;
	Tue, 19 Apr 2011 21:42:17 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: Brandon Gooch <jamesbrandongooch@gmail.com>
Date: Tue, 19 Apr 2011 17:41:57 -0400
User-Agent: KMail/1.6.2
References: <20110420003133.4dc391f6.taku@tackymt.homeip.net>
	<201104191702.14715.jkim@FreeBSD.org>
	<BANLkTinfuX4whxbs3szbd1aTNaxxQ5Z2LQ@mail.gmail.com>
In-Reply-To: <BANLkTinfuX4whxbs3szbd1aTNaxxQ5Z2LQ@mail.gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201104191742.09449.jkim@FreeBSD.org>
Cc: freebsd-acpi@freebsd.org
Subject: Re: [PATCH] Move scsuspend()/scresume() forward to EVENTHANDLERs
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Apr 2011 21:42:18 -0000

On Tuesday 19 April 2011 05:27 pm, Brandon Gooch wrote:
> On Tue, Apr 19, 2011 at 4:02 PM, Jung-uk Kim <jkim@freebsd.org> 
wrote:
> > On Tuesday 19 April 2011 04:55 pm, Brandon Gooch wrote:
> >> On Tue, Apr 19, 2011 at 3:24 PM, Jung-uk Kim <jkim@freebsd.org>
> >
> > wrote:
> >> > On Tuesday 19 April 2011 04:02 pm, Warner Losh wrote:
> >> >> Having chased boogiemen in this area before, I think this
> >> >> patch makes good sense even though it breaks the device model
> >> >> a little. However, the hardware in question really is special
> >> >> on x86...
> >> >>
> >> >> Warner
> >> >
> >> > Actually I was working on a similar patch and it should be
> >> > ready soon.
> >> >
> >> > Jung-uk Kim
> >>
> >> You have a willing (if not completely capable) tester here, so I
> >> always look forward to your patches.
> >>
> > :-)
> >
> > http://people.freebsd.org/~jkim/syscons.diff
> >
> > Also attached here.
>
> Cool, building now...
>
> I noticed you didn't grab the Giant lock, which shouldn't be needed
> since Ed's work, correct?

Actually the real reason is locking is completely missing in 
syscons(4) since we abandoned spltty().  Grabbing Giant here makes no 
difference because of that reason. :-(

> >> As the situation has greatly improved, I hesitate to even say
> >> this, but...I wish the USB stack could be made to be
> >> suspend/resume resilient. It's really the only problem child in
> >> my laptop. Fortunately, it's easy enough to build the USB stack
> >> as modules and unload/reload them.
> >
> > I tried to do something about it but new USB stack is completely
> > out of my expertise, unfortunately. :-(
> >
> > Jung-uk Kim
>
> I understand, and again, I know it seems like I always bring it up
> to you whenever I get the chance -- because I do. Sorry :|

That's okay, I'm used to it. ;-)

> I should bug someone else (Hans or Andrew Thompson), or maybe the
> PC-BSD guys might get interested in fixing this eventually -- after
> GEM, KMS, etc... ;)

Yeah, maybe...

Jung-uk Kim