From nobody Sat Sep 23 07:53:44 2023 X-Original-To: toolchain@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rt1br3Tp6z4vDpq for ; Sat, 23 Sep 2023 07:53:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rt1br1pcSz4P00 for ; Sat, 23 Sep 2023 07:53:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695455624; a=rsa-sha256; cv=none; b=MjdUWuWiyzh5o5soWqHKSb5EZYWO86nJh4wm/q7f5X2ABgGCkkc6mNxVlyZjB8yK3UhXyN 4pEKtUeoQb4bxWGEhDaOZXdkboDeO+Bv8jagFxBlEFa78fyJE9krRr+jpCEIaJbdEpBnba ixJmbgZjotN5ByzmYru0cINUYT8Cdd+EvwMwqH6Vqlk9RTgDn0Xdbo3Z+Q3PbfhbfaLKAo JRgbSAOQZ2Zf3UwMkyCFMnXeSAQfPjeMZ9mgoA1bcNK9hDfdhz/mhv8f067/AZ9gw3dTYV eLfrNPTuCj+bH/TbUboxlvudk9ff4yoah2PF8gPUtoWC1CHdXzScaVpK1wD0Vg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695455624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TMUv6E45Qk7QoDrPxatPAzGKBFHVOtuZ6eor01YFeSc=; b=SZKTQJToy5oXg8yUMZnE4LkxYcuuFm9FteuaL5Du/k9nw5QC8872OrEssiee6oHQrr+jaQ GFvlsoziXZdxgtpPPlu5DWxioCr9AaqACzMDAs28iDkysHCWRcDQikwiiLVToVFgEj5uhW GyIhq+NQV9atJOQ7JV5LqYaf5KfHHZJyl/R+jgdGNNWgs9OrmTgC184mlzsihX+IVfwb5n LcCLRxxXZP+Df0rTpfAeuV+Rqb8Dh/WCz2F3lOZpxiCejsn6v4UvyvzQfRBqUsXc6GzXTP nciWWVFhGfktdCaz1DAQg/Ye57/y1Mzblxo/s7ihFHjCVY+Ta5Wzy2WTqf21TA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rt1br0vBtzwWW for ; Sat, 23 Sep 2023 07:53:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 38N7ri6x037155 for ; Sat, 23 Sep 2023 07:53:44 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 38N7ri0P037154 for toolchain@FreeBSD.org; Sat, 23 Sep 2023 07:53:44 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: toolchain@FreeBSD.org Subject: maintainer-feedback requested: [Bug 274042] lang/gcc8 lang/gcc9: fix build with libc++ 17 Date: Sat, 23 Sep 2023 07:53:44 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: toolchain@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Maintenance of FreeBSD s integrated toolchain List-Archive: https://lists.freebsd.org/archives/freebsd-toolchain List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org MIME-Version: 1.0 Bugzilla Automation has asked freebsd-toolchain (Nob= ody) for maintainer-feedback: Bug 274042: lang/gcc8 lang/gcc9: fix build with libc++ 17 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274042 --- Description --- When building relatively recent gcc ports (with C++ in them) against libc++= 17, you get errors similar to: In file included from /wrkdirs/usr/ports/lang/gcc12/work/gcc-12.2.0/gcc/cp/module.cc:208: In file included from /wrkdirs/usr/ports/lang/gcc12/work/gcc-12.2.0/gcc/system.h:239: In file included from /usr/include/c++/v1/vector:321: In file included from /usr/include/c++/v1/__format/formatter_bool.h:20: In file included from /usr/include/c++/v1/__format/formatter_integral.h:32: In file included from /usr/include/c++/v1/locale:202: /usr/include/c++/v1/__locale:546:5: error: '__abi_tag__' attribute only app= lies to structs, variables, functions, and namespaces 546 | _LIBCPP_INLINE_VISIBILITY | ^ /usr/include/c++/v1/__config:813:37: note: expanded from macro '_LIBCPP_INLINE_VISIBILITY' 813 | # define _LIBCPP_INLINE_VISIBILITY _LIBCPP_HIDE_FROM_ABI | ^ /usr/include/c++/v1/__config:792:26: note: expanded from macro '_LIBCPP_HIDE_FROM_ABI' 792 |=20=09=20 __attribute__((__abi_tag__(_LIBCPP_TOSTRING(_LIBCPP_VERSIONED_IDENTIFIER)))) | ^ In file included from /wrkdirs/usr/ports/lang/gcc12/work/gcc-12.2.0/gcc/cp/module.cc:208: In file included from /wrkdirs/usr/ports/lang/gcc12/work/gcc-12.2.0/gcc/system.h:239: In file included from /usr/include/c++/v1/vector:321: In file included from /usr/include/c++/v1/__format/formatter_bool.h:20: In file included from /usr/include/c++/v1/__format/formatter_integral.h:32: In file included from /usr/include/c++/v1/locale:202: /usr/include/c++/v1/__locale:547:37: error: expected ';' at end of declarat= ion list 547 | char_type toupper(char_type __c) const | ^ /usr/include/c++/v1/__locale:553:48: error: too many arguments provided to function-like macro invocation 553 | const char_type* toupper(char_type* __low, const char_type* __h= igh) const | ^ /wrkdirs/usr/ports/lang/gcc12/work/gcc-12.2.0/gcc/../include/safe-ctype.h:1= 46:9 : note: macro 'toupper' defined here 146 | #define toupper(c) do_not_use_toupper_with_safe_ctype | ^ This is because gcc/system.h includes safe-ctype.h which redefines ctype ma= cros such as toupper, tolower, etc to "poison" them. However, it should only include the safe-ctype.h header *after* any C++ headers, such as , , , etc, otherwise these might transitively include internal ctype headers (such as with libc++ 17), causi= ng the above conflicts. Here is a patch that moves the safe-ctype.h inclusion to later in gcc/syste= m.h, which solves this issue, and makes it possible to build against libc++ 17.