From owner-svn-src-all@FreeBSD.ORG Mon Jul 9 21:15:29 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5E422106566C; Mon, 9 Jul 2012 21:15:29 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 882CE8FC12; Mon, 9 Jul 2012 21:15:28 +0000 (UTC) Received: by weyx56 with SMTP id x56so495775wey.13 for ; Mon, 09 Jul 2012 14:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:x-comment-to:sender:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=f7HNDWpqw3RSN6G8pf5Tadwciu6Lw6ppvuNyUgZbjFw=; b=odZhgPuzmCCAGI2nibiM7XKoyBZdmVKKkceOhRja/bNix+wMGm/9oLKEjqp81EFwV4 rpbu0aktKlPJbanbGA2UQz6TCNRsfiBRKI5cru2UT+gTLGkX4mg88iYVJcV0WDXrxhkB xz5Wu+df9Biw8nHiehKjgDAjapgeBOSzLPGsKTrFZf2rT6/HOR4GR+so3n9AKN+VIMbV FpiVI/dwVKfrfFCLfkEJdwRDUtV7VplRzKZVrKkb+r/OQkbydZvBAuny+ffO1y8LPvOK Ij0b6oRxlp2/FN41VTB7ciV3jKBiah/9v4LxwUPrlfd4TP3N22drXfjTJVk0tIx4q6Tu 9KiQ== Received: by 10.180.84.104 with SMTP id x8mr32488764wiy.20.1341868527665; Mon, 09 Jul 2012 14:15:27 -0700 (PDT) Received: from localhost ([95.69.175.25]) by mx.google.com with ESMTPS id w7sm18839599wiz.0.2012.07.09.14.15.25 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 09 Jul 2012 14:15:26 -0700 (PDT) From: Mikolaj Golub To: d@delphij.net References: <201207092038.q69KcIi1038787@svn.freebsd.org> <4FFB43CD.4070802@delphij.net> X-Comment-To: Xin Li Sender: Mikolaj Golub Date: Tue, 10 Jul 2012 00:15:24 +0300 In-Reply-To: <4FFB43CD.4070802@delphij.net> (Xin Li's message of "Mon, 09 Jul 2012 13:49:17 -0700") Message-ID: <86sjd0vdoz.fsf@kopusha.home.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r238309 - head/sys/net X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2012 21:15:29 -0000 On Mon, 09 Jul 2012 13:49:17 -0700 Xin Li wrote: XL> On 07/09/12 13:38, Mikolaj Golub wrote: >> Author: trociny Date: Mon Jul 9 20:38:18 2012 New Revision: >> 238309 URL: http://svn.freebsd.org/changeset/base/238309 >> >> Log: In epair_clone_destroy(), when destroying the second half, we >> have to switch to its vnet before calling ether_ifdetach(). >> Otherwise if the second half resides in a different vnet, >> if_detach() silently fails leaving a stale pointer in V_ifnet list, >> and the system crashes trying to access this pointer later. >> >> Another solution could be not to allow to destroy epair unless >> both ends are in the home vnet. >> >> Discussed with: bz Tested by: delphij XL> Thanks! XL> Since this affects RELENG_9 and RELENG_8, could you please also MFC XL> after a settle period? Sure. Just forgot to add the 'MFC after' reminder. I am going to MFC it after stable/9 unfreeze unless someone really wants it in 9.1 and tests it a little. This does not look like a critical issue because of the existing workaround (which can be considered as a best practice): move both ends to the home vnet before destroying the epair. -- Mikolaj Golub