From owner-freebsd-current@FreeBSD.ORG  Wed Mar 11 16:38:46 2015
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B6A48991
 for <freebsd-current@FreeBSD.ORG>; Wed, 11 Mar 2015 16:38:46 +0000 (UTC)
Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net
 [199.48.129.229]) by mx1.freebsd.org (Postfix) with ESMTP id 91E3D932
 for <freebsd-current@FreeBSD.ORG>; Wed, 11 Mar 2015 16:38:46 +0000 (UTC)
Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001)
 id 0EC835A9F27; Wed, 11 Mar 2015 16:38:40 +0000 (UTC)
Date: Wed, 11 Mar 2015 16:38:39 +0000
From: Brooks Davis <brooks@freebsd.org>
To: Hans Petter Selasky <hps@selasky.org>
Subject: Re: Extending PATH variable in top-level Makefile
Message-ID: <20150311163839.GA68977@spindle.one-eyed-alien.net>
References: <5500171D.6060303@selasky.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="ikeVEW9yuYc//A+q"
Content-Disposition: inline
In-Reply-To: <5500171D.6060303@selasky.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: freebsd-current@FreeBSD.ORG
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Mar 2015 16:38:46 -0000


--ikeVEW9yuYc//A+q
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 11, 2015 at 11:21:17AM +0100, Hans Petter Selasky wrote:
> Hi,
>=20
> When installing bmake from ports, the binary ends up in /usr/local/bin=20
> and our top-level Makefile doesn't check there:
>=20
> diff --git a/Makefile b/Makefile
> index e89a5b1..35ade48 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -129,7 +129,7 @@ TGTS+=3D      ${BITGTS}
>   .ORDER: buildkernel reinstallkernel
>   .ORDER: buildkernel reinstallkernel.debug
>=20
> -PATH=3D  /sbin:/bin:/usr/sbin:/usr/bin
> +PATH=3D  /sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin
>=20
>=20
> > bmake -m $PWD/share/mk buildkernel
> > env: bmake: No such file or directory
> > bmake: "/usr/img/freebsd/Makefile" line 136: warning: "/usr/bin/env -i =
PATH=3D/sbin:/bin:/usr/sbin:/usr/bin bmake   __MAKE_CONF=3D/etc/make.conf  =
-f /dev/null -V MAKEOBJDIRPREFIX dummy" returned non-zero status
> > --- buildkernel ---
> > --- buildkernel ---
> > ERROR: Missing kernel configuration file(s) (NOIP).
> > *** [buildkernel] Error code 1
> >
>=20
> Any objections against extending the PATH=3D in our top-level Makefile?

I can't express how bad I think that idea is.  You should be able to just u=
se
a full path to the installed bmake.  I'm surprised you need -m.

-- Brooks

--ikeVEW9yuYc//A+q
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlUAb48ACgkQXY6L6fI4GtTOtACgy7wc9DdrB9z1AWVW7C5jKJUk
MuAAnifJ55I1edqbhK8FExzsx2eyziv6
=0ACP
-----END PGP SIGNATURE-----

--ikeVEW9yuYc//A+q--