From owner-freebsd-ports Fri Mar 17 5:19:45 2000 Delivered-To: freebsd-ports@freebsd.org Received: from argon.blackdawn.com (deepspace9.dcds.edu [207.231.151.2]) by hub.freebsd.org (Postfix) with ESMTP id C63FB37BC68; Fri, 17 Mar 2000 05:19:39 -0800 (PST) (envelope-from will@blackdawn.com) Received: by argon.blackdawn.com (Postfix, from userid 1000) id B10061999; Fri, 17 Mar 2000 08:19:36 -0500 (EST) Date: Fri, 17 Mar 2000 08:19:36 -0500 From: Will Andrews To: Hajimu UMEMOTO Cc: FreeBSD Ports Subject: Re: Can this get added Message-ID: <20000317081936.A3722@argon.blackdawn.com> References: <20000316144042.B28224@lunatic.oneinsane.net> <20000317151736D.ume@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: <20000317151736D.ume@FreeBSD.org>; from ume@FreeBSD.ORG on Fri, Mar 17, 2000 at 03:17:36PM +0900 X-Operating-System: FreeBSD 5.0-CURRENT i386 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Fri, Mar 17, 2000 at 03:17:36PM +0900, Hajimu UMEMOTO wrote: > I wrote FreeBSD part of it. > I also made the port to intend to commit: > > http://www.freebsd.org/~ume/gkrellm/gkrellm-port-20000315.tar.gz THANKS for working on this! I tried to port this program about six to nine months ago, with no success.. although that can mostly be blamed on the fact that back then I was not (and am still not) very familiar with FreeBSD process statistic obtainment (I know it's through kvm though). > I had some discussion with the author of GKrellM about making port and > OKed from him. > I had test it on: > > 4.0-CURRENT > 3.4-RELEASE > 3.4-RELEASE + KAME > 3.4-RELEASE + KAME + PAO > 2.2.8-STABLE > 2.2.8-STABLE + KAME Add to that: FreeBSD 5.0-CURRENT (my box) > If OK, I'll commit it. Looks fine, except that the gtk12.2 LIB_DEPENDS is implied througH gdk_imlib.5. The message in the Makefile about suid root for temperatures - you should put this in ${PKGDIR}/MESSAGE or similar and output it at the end of the installation (post-install target). Also, in the do-install target, you could use .for and .endfor instead of @for [...]. Another thing: your port does not respect CC/CFLAGS. At least that's what I gather from "gcc -Wall -O -pipe -O2". ;-) BTW: Why does gkrellm belong in the ipv6 category? :) -- Will Andrews GCS/E/S @d- s+:+>+:- a--->+++ C++ UB++++ P+ L- E--- W+++ !N !o ?K w--- ?O M+ V-- PS+ PE++ Y+ PGP+>+++ t++ 5 X++ R+ tv+ b++>++++ DI+++ D+ G++>+++ e->++++ h! r-->+++ y? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message