From owner-freebsd-ports@FreeBSD.ORG  Fri Mar 28 16:35:26 2008
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 87D11106564A
	for <freebsd-ports@FreeBSD.org>; Fri, 28 Mar 2008 16:35:26 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx24.fluidhosting.com [204.14.89.7])
	by mx1.freebsd.org (Postfix) with SMTP id 1B7828FC22
	for <freebsd-ports@FreeBSD.org>; Fri, 28 Mar 2008 16:35:25 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: (qmail 19039 invoked by uid 399); 28 Mar 2008 16:42:04 -0000
Received: from localhost (HELO lap.dougb.net) (dougb@dougbarton.us@127.0.0.1)
	by localhost with ESMTP; 28 Mar 2008 16:42:04 -0000
X-Originating-IP: 127.0.0.1
Message-ID: <47ED1E46.3050409@FreeBSD.org>
Date: Fri, 28 Mar 2008 09:35:18 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Thunderbird 2.0.0.12 (X11/20080319)
MIME-Version: 1.0
To: Roman Divacky <rdivacky@FreeBSD.org>
References: <1206548309.78560.69.camel@pav.hide.vol.cz>	<20080326201416.GA34807@freebsd.org>
	<47EC5589.7070207@FreeBSD.org> <20080328082241.GA48417@freebsd.org>
In-Reply-To: <20080328082241.GA48417@freebsd.org>
X-Enigmail-Version: 0.95.6
OpenPGP: id=D5B2F0FB
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Pav Lucistnik <pav@FreeBSD.org>, soralx@cydem.org,
	freebsd-ports@FreeBSD.org
Subject: Re: [patch] pkg_delete(1) speedup
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Mar 2008 16:35:26 -0000

Roman Divacky wrote:

> there are 3 style-only changes in the patch.. 3 lines.. I didnt consider
> to make two separate patches for testing/review :)
> 
> I'll do it if you insist....

Think of it as good practice. :) Seriously though, it does make the 
CVS history a little easier to examine. Your best bet is to generate a 
diff that contains only the style changes, then diff the substantive 
changes against the new version. That way if you have to make changes 
to the substance later on down the road you won't have to worry about 
reapplying the style changes.

hth,

Doug

-- 

     This .signature sanitized for your protection