From owner-svn-ports-all@freebsd.org Mon Mar 20 16:15:41 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B00D1D1474E; Mon, 20 Mar 2017 16:15:41 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4A27B1DE1; Mon, 20 Mar 2017 16:15:40 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-wm0-f49.google.com with SMTP id n11so67654390wma.1; Mon, 20 Mar 2017 09:15:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=PA1p3q1agx7cTWIBEpXKKVStZfevmneHirWpqsK6y7I=; b=WFR2lY43kHcHzDazYfuWRVgrbd/TRFdDRPuZMPTDxzogTgjlPHyof1BTsuwpAQ7Ndi rnLNYmJrWO67iMBMX3QS9Lo2Yy+RPDw3nYiJKOCa9eedxKvVusEpDFM5N2EVxlpIpANc h6r/JGDukUTtuTS6qjHQc5CPD/CWgMZPd/kdgfp7++dVvsBv6HNrPVGSuznEZ6CUeG5f lsP4nPyXNplQ94Pv+vMAkKGhmQZAb/JNUwHiei9jXeha+YOhpsJR31K6x2r0i99cev1s CooTdscmVGWPagocxrk0D84XykB9/lLdOhuqqyNP1RkibOmdtYB5DCeF3Z92s76Hr/m7 iYcg== X-Gm-Message-State: AFeK/H3lymPMLoteK27IjxNivFnZq3Cf1jftHGWE4g04B0bNML4GvLmTAYLSo6l3Opp4YQ== X-Received: by 10.28.31.139 with SMTP id f133mr10783542wmf.25.1490024766261; Mon, 20 Mar 2017 08:46:06 -0700 (PDT) Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com. [209.85.128.177]) by smtp.gmail.com with ESMTPSA id y1sm13840382wme.15.2017.03.20.08.46.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Mar 2017 08:46:06 -0700 (PDT) Received: by mail-wr0-f177.google.com with SMTP id u108so95169742wrb.3; Mon, 20 Mar 2017 08:46:06 -0700 (PDT) X-Received: by 10.223.150.211 with SMTP id u77mr26132160wrb.6.1490024765897; Mon, 20 Mar 2017 08:46:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.39.134 with HTTP; Mon, 20 Mar 2017 08:45:45 -0700 (PDT) In-Reply-To: <201703050813.v258DSQt052933@repo.freebsd.org> References: <201703050813.v258DSQt052933@repo.freebsd.org> From: Kyle Evans Date: Mon, 20 Mar 2017 10:45:45 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r435456 - in head: comms/wy60 deskutils/gbirthday devel/arduino-builder devel/cityhash devel/google-gdata devel/monodevelop emulators/citra games/openomf security/ssh-vault To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Mar 2017 16:15:41 -0000 On Sun, Mar 5, 2017 at 2:13 AM, Mathieu Arnold wrote: > Author: mat > Date: Sun Mar 5 08:13:28 2017 > New Revision: 435456 > URL: https://svnweb.freebsd.org/changeset/ports/435456 > > Log: > Cleanup USE_GITHUB with GH_TUPLE usage. > > Do not use GH_TUPLE for the default distfile. > > With hat: portmgr > Sponsored by: Absolight > > Modified: > head/comms/wy60/Makefile (contents, props changed) > head/deskutils/gbirthday/Makefile (contents, props changed) > head/devel/arduino-builder/Makefile (contents, props changed) > head/devel/cityhash/Makefile (contents, props changed) > head/devel/google-gdata/Makefile (contents, props changed) > head/devel/monodevelop/Makefile (contents, props changed) > head/devel/monodevelop/distinfo (contents, props changed) > head/emulators/citra/Makefile (contents, props changed) > head/games/openomf/Makefile (contents, props changed) > head/security/ssh-vault/Makefile (contents, props changed) > > [...] > Modified: head/devel/arduino-builder/Makefile > ============================================================================== > --- head/devel/arduino-builder/Makefile Sun Mar 5 08:09:35 2017 (r435455) > +++ head/devel/arduino-builder/Makefile Sun Mar 5 08:13:28 2017 (r435456) > @@ -15,7 +15,7 @@ BUILD_DEPENDS= go:lang/go > > USE_GITHUB= yes > GH_ACCOUNT= arduino > -GH_SUBDIR= src/github.com/${GH_ACCOUNT}/${PORTNAME} > +GH_SUBDIR= src/github.com/${GH_ACCOUNT_DEFAULT}/${PORTNAME} > GH_TUPLE= go-errors:errors:a418503:goerrors/src/github.com/go-errors/errors \ > stretchr:testify:v1.1.3:stretchr/src/github.com/stretchr/testify \ > jstemmer:go-junit-report:833f8ea:jstemmer/src/github.com/jstemmer/go-junit-report Hi, With respect to the above change, may I ask where GH_ACCOUNT vs. GH_ACCOUNT_DEFAULT is most appropriately used? I'm not finding any documentation for the latter, but is it safe to assume that if I think I need to use GH_ACCOUNT elsewhere in the Makefile I should likely be using GH_ACCOUNT_DEFAULT instead?