Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 4 Feb 2020 19:19:48 +0000 (UTC)
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r357517 - in stable: 10/libexec/rbootd 11/libexec/rbootd 12/libexec/rbootd
Message-ID:  <202002041919.014JJmkP046562@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dim
Date: Tue Feb  4 19:19:48 2020
New Revision: 357517
URL: https://svnweb.freebsd.org/changeset/base/357517

Log:
  MFC r357223:
  
  Merge r357222 from the clang1000-import branch:
  
  Fix the following -Werror warning from clang 10.0.0 in rbootd:
  
  libexec/rbootd/rmpproto.c:335:49: error: multiple unsequenced modifications to 'filename' [-Werror,-Wunsequenced]
          filename = (filename = strrchr(filepath,'/'))? ++filename: filepath;
                   ~                                     ^

Modified:
  stable/11/libexec/rbootd/rmpproto.c
Directory Properties:
  stable/11/   (props changed)

Changes in other areas also in this revision:
Modified:
  stable/10/libexec/rbootd/rmpproto.c
  stable/12/libexec/rbootd/rmpproto.c
Directory Properties:
  stable/10/   (props changed)
  stable/12/   (props changed)

Modified: stable/11/libexec/rbootd/rmpproto.c
==============================================================================
--- stable/11/libexec/rbootd/rmpproto.c	Tue Feb  4 19:15:57 2020	(r357516)
+++ stable/11/libexec/rbootd/rmpproto.c	Tue Feb  4 19:19:48 2020	(r357517)
@@ -330,7 +330,8 @@ SendBootRepl(struct rmp_packet *req, RMPCONN *rconn, c
 	 *  stripped file name and spoof the client into thinking that it
 	 *  really got what it wanted.
 	 */
-	filename = (filename = strrchr(filepath,'/'))? ++filename: filepath;
+	filename = strrchr(filepath,'/');
+	filename = filename? filename + 1: filepath;
 
 	/*
 	 *  Check that this is a valid boot file name.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202002041919.014JJmkP046562>