From nobody Fri Dec 27 14:24:46 2024 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YKSST71dYz5hbW7 for ; Fri, 27 Dec 2024 14:24:57 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YKSST69sFz4cRS; Fri, 27 Dec 2024 14:24:57 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735309497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rpiibNfa+NOLaif2MQCCKtEcx1UI30ifxgNK5/pycP4=; b=SObPELrCHQNEiTag0bIrSgK3VyotX0ZrCmnAfiECrPtOVnkCpAn3SgjsgsjQyTx2J0RvHn +mLQ1+SBkY42bIjbyQMKl4u4eKAvagZH0pgHZ7/DGvufuqXWfutbgkvUUVDixzEvMwTajl z3eQsfvwsEEhL/ZBR8GlHvSL1U1xMRtCSgvMUPd0otGGqND6owIXBZsTwVshadrtRCHS9+ DG+BNLNIjx5jmufv1+0MDkcYst2PljtxOI5xYbZAbpCvKNDHgWaKMI6P2LKAB/88agMwRg G/M0IfnkUzgSswiMStTUzvGjuUeCcgnSz/GDZSge9H8/qKTJ4yU19OeRb9uLwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735309497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rpiibNfa+NOLaif2MQCCKtEcx1UI30ifxgNK5/pycP4=; b=uYsvZ+nuDkaK2+0WIzVB87ZIygXOo4sSFm6ZHfkFd+MLyHEoAxrYITfcZ49TNIrlZZ1eyo XqLQBGkPvNLbZcYoIRToXkhv+bMMMbmRH09pxSrNiXU6s9c10ob1qbAC1OC2ZOm9pwQJwp cuIHq+PmnK0XQO0bXDQ9VbezdqJjRdYgCqJa6VtrUrpKixTcIpbJgTq8NWgskcJJd61rGa qvqBGfkCtjrVeT/w+iQIrXZNdkmbhUYUpr05EVnf8BXr54E/LE6Xxwts4IWtgVLN33vRvR A76+NigfJ3qLeZloPWBuwwifb+11q84UHofoFgmRPq04+Ig1WcO5EtGDlULT2w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1735309497; a=rsa-sha256; cv=none; b=tOwvCgercenP1Bhpxv+v+ar3zlMyDOyv9qEgej6CImfNpMGEF9g76TwaaZXgusy+mj4Gux DpcJZFn0vwdCOpXO9Xe3l3TshESRwdRaNcSS+/Tkd2kzHSsxWniq82sDF/OuW5JUC653Mo Eq3PE17Zo9lQdOvuAzz5KM4JH0rbTcJd/pBXV5OW8+Ca+BwoQTIxhMOkjnPYUm3qemHk12 UTGjqxJIL+7Os2IM0rJmyKcLA3UV2cVLc1el6pve/rR4f/nka43LUY7xFARgO710Znh9YF tfESGUXqCqtiw06iiLG2gkBIM1t65f3+XL22LlFmHZXa2XZEi2OJUllNvHHm2g== Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YKSST5cMmzjCl; Fri, 27 Dec 2024 14:24:57 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-7b6e9dd985dso92670485a.2; Fri, 27 Dec 2024 06:24:57 -0800 (PST) X-Gm-Message-State: AOJu0YxBBG5YvymCppfFIUb7bJ/STbS81eYHo8rhg/OW2f/9ZVI6QRIY KTgUbj6lxkC2lgyqN188prXGlqv2+5IrYE55bbovB4jY7QGdOE9P/De4uWDgiF2+3yUVTKrqwio SgGB1wIQ6VBti7tFZXJyDvBnCkZk= X-Google-Smtp-Source: AGHT+IE8IBPH6IcJ++gzkdtacxEpuxhlnqKAfof4NV1MEesEjYPYQNTKt3AHIBFdEST3GikJVqiMyz96/M4jWosgDj4= X-Received: by 2002:a05:620a:4053:b0:7b6:7031:e15e with SMTP id af79cd13be357-7b9ba7eab6cmr1552570285a.16.1735309497312; Fri, 27 Dec 2024 06:24:57 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 References: In-Reply-To: From: Nuno Teixeira Date: Fri, 27 Dec 2024 14:24:46 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: base64.h problems with rtorent port To: Baptiste Daroussin Cc: FreeBSD CURRENT Content-Type: multipart/alternative; boundary="00000000000029aca1062a413a64" --00000000000029aca1062a413a64 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Perfect! I'm thinking using a radio option where we can select one of xml parsers or none as supported upstream, defaulting to TINYXML. A quick look in repology shows that at least 3 linux distros use directly `--with-xmlrpc-tinyxml2` with 0.15.0 pkgs. I'm ok with simplifying port or keep radio option. Cheers! ``` OPTIONS_DEFINE=3D DOCS EXAMPLES IPV6 OPTIONS_DEFAULT=3D TINYXML OPTIONS_RADIO=3D XML OPTIONS_RADIO_XML=3D TINYXML XMLRPC XMLRPC_DESC=3D Compile with xmlrpc-c support IPV6_CONFIGURE_ENABLE=3D ipv6 TINYXML_CONFIGURE_ON=3D --with-xmlrpc-tinyxml2 XMLRPC_LIB_DEPENDS=3D libxmlrpc.so:net/xmlrpc-c XMLRPC_CONFIGURE_ON=3D --with-xmlrpc-c ``` Baptiste Daroussin escreveu (sexta, 27/12/2024 =C3=A0(s) 13:17): > On Fri 27 Dec 12:48, Nuno Teixeira wrote: > > Hello Baptiste, > > > > Yes, this proves that my C skills are awesome :) > > > > Upstream spotted it too, and in fact, base64.h is missing from tarball. > > Now I'm waiting on upstream to find the best and fast way to include > > missing file so I can test build. > > > > Thanks very much, > > I have sent a PR which should fix the issue they need to reroll their > distfiles. > --=20 Nuno Teixeira FreeBSD UNIX: Web: https://FreeBSD.org --00000000000029aca1062a413a64 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Perfect!

I'm thinking using a r= adio option where we can select one of xml parsers or none as supported ups= tream, defaulting to TINYXML.

A quick look in repo= logy shows that at least 3 linux distros use directly `--with-xmlrpc-tinyxm= l2` with 0.15.0 pkgs. I'm ok with simplifying port or keep radio option= .

Cheers!

```
= OPTIONS_DEFINE=3D =C2=A0 =C2=A0 =C2=A0 =C2=A0 DOCS EXAMPLES IPV6
OPTIONS= _DEFAULT=3D =C2=A0 =C2=A0 =C2=A0 =C2=A0TINYXML
OPTIONS_RADIO=3D =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0XML
OPTIONS_RADIO_XML=3D =C2=A0 =C2=A0 =C2=A0= TINYXML XMLRPC
XMLRPC_DESC=3D =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0C= ompile with xmlrpc-c support

IPV6_CONFIGURE_ENABLE=3D =C2=A0ipv6
= TINYXML_CONFIGURE_ON=3D =C2=A0 --with-xmlrpc-tinyxml2
XMLRPC_LIB_DEPENDS= =3D =C2=A0 =C2=A0 libxmlrpc.so:net/xmlrpc-c
XMLRPC_CONFIGURE_ON=3D =C2= =A0 =C2=A0--with-xmlrpc-c
```

Baptiste Da= roussin <bapt@freebsd.org> es= creveu (sexta, 27/12/2024 =C3=A0(s) 13:17):
On Fri 27 Dec 12:48, Nuno Teixeira wrote:
> Hello Baptiste,
>
> Yes, this proves that my C skills are awesome :)
>
> Upstream spotted it too, and in fact, base64.h is missing from tarball= .
> Now I'm waiting on upstream to find the best and fast way to inclu= de
> missing file so I can test build.
>
> Thanks very much,

I have sent a PR which should fix the issue they need to reroll their distf= iles.


--
Nuno Teixeira
=
FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 https://Fr= eeBSD.org
--00000000000029aca1062a413a64--