From owner-svn-src-head@freebsd.org Mon Jun 1 22:00:50 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 78E7A2F4310; Mon, 1 Jun 2020 22:00:50 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from forward501j.mail.yandex.net (forward501j.mail.yandex.net [IPv6:2a02:6b8:0:801:2::111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49bTdF0Pzlz3dZw; Mon, 1 Jun 2020 22:00:48 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from mxback8j.mail.yandex.net (mxback8j.mail.yandex.net [IPv6:2a02:6b8:0:1619::111]) by forward501j.mail.yandex.net (Yandex) with ESMTP id DEF963380195; Tue, 2 Jun 2020 01:00:44 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback8j.mail.yandex.net (mxback/Yandex) with ESMTP id Juq3NTd822-0hneMMmE; Tue, 02 Jun 2020 01:00:44 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfw.ru; s=mail; t=1591048844; bh=VFcsldl8Iuz+FskuU9Kl/0JqmSlClodwNFmCWYy2b8s=; h=Message-Id:Cc:Subject:In-Reply-To:Date:References:To:From; b=J/YJ+kw2W39EYgBr31vnRnYeusSB++jW51Ai3Xu2oxlhV9j5DnH1pUmD613QfRFZP pobdCiqyPVEOneFUeuS5aj+Z0xxJU1BXECHmqgmUtD+MLjoi8tgJcvU5JKWUrnZcm5 DnX4rljjvEcUzL14KoNtDnXy8++/QEaUM6Kx2WEU= Received: by iva4-64850291ca1c.qloud-c.yandex.net with HTTP; Tue, 02 Jun 2020 01:00:42 +0300 From: Alexander V. Chernikov Envelope-From: melifaro@ipfw.ru To: Cy Schubert , Michael Tuexen Cc: src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" In-Reply-To: <202006012143.051LhS8D073952@slippy.cwsent.com> References: <202006012049.051KnhxX060695@repo.freebsd.org> <6FE2C649-2D81-4C9C-B821-D8226B6BB95C@fh-muenster.de> <202006012143.051LhS8D073952@slippy.cwsent.com> Subject: Re: svn commit: r361706 - in head/sys: net net/route netinet netinet6 MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Mon, 01 Jun 2020 23:00:42 +0100 Message-Id: <1493091591048645@mail.yandex.ru> Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 X-Rspamd-Queue-Id: 49bTdF0Pzlz3dZw X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=ipfw.ru header.s=mail header.b=J/YJ+kw2; dmarc=none; spf=pass (mx1.freebsd.org: domain of melifaro@ipfw.ru designates 2a02:6b8:0:801:2::111 as permitted sender) smtp.mailfrom=melifaro@ipfw.ru X-Spamd-Result: default: False [-3.28 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[ipfw.ru:s=mail]; NEURAL_HAM_MEDIUM(-0.99)[-0.994]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a02:6b8:0::/52]; NEURAL_HAM_LONG(-0.95)[-0.954]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[ipfw.ru:+]; NEURAL_HAM_SHORT(-1.03)[-1.035]; FORGED_SENDER(0.30)[melifaro@freebsd.org,melifaro@ipfw.ru]; RCVD_IN_DNSWL_LOW(-0.10)[2a02:6b8:0:801:2::111:from]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:13238, ipnet:2a02:6b8::/32, country:RU]; FROM_NEQ_ENVFROM(0.00)[melifaro@freebsd.org,melifaro@ipfw.ru] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2020 22:00:50 -0000 01.06.2020, 22:43, "Cy Schubert" : > In message <6FE2C649-2D81-4C9C-B821-D8226B6BB95C@fh-muenster.de>, Michael > Tuexe > n writes: >>  --Apple-Mail=_30A6D176-B5FA-4F13-A949-3CE33C73C3B8 >>  Content-Transfer-Encoding: quoted-printable >>  Content-Type: text/plain; >>          charset=us-ascii >> >>  > On 1. Jun 2020, at 22:49, Alexander V. Chernikov = >>   wrote: >>  >=20 >>  > Author: melifaro >>  > Date: Mon Jun 1 20:49:42 2020 >>  > New Revision: 361706 >>  > URL: https://svnweb.freebsd.org/changeset/base/361706 >>  >=20 >>  > Log: >>  > * Add rib__route() functions to manipulate the = >>  routing table. >>  >=20 >>  > The main driver for the change is the need to improve notification = >>  mechanism. >>  > Currently callers guess the operation data based on the rtentry = >>  structure >>  > returned in case of successful operation result. There are two = >>  problems with >>  > this appoach. First is that it doesn't provide enough information = >>  for the >>  > upcoming multipath changes, where rtentry refers to a new nexthop = >>  group, >>  > and there is no way of guessing which paths were added during the = >>  change. >>  > Second is that some rtentry fields can change during notification = >>  and >>  > protecting from it by requiring customers to unlock rtentry is not = >>  desired. >>  >=20 >>  > Additionally, as the consumers such as rtsock do know which operation = >>  they >>  > request in advance, making explicit add/change/del versions of the = >>  functions >>  > makes sense, especially given the functions don't share a lot of = >>  code. >>  >=20 >>  > With that in mind, introduce rib_cmd_info notification structure and >>  > rib__route() functions, with mandatory rib_cmd_info = >>  pointer. >>  > It will be used in upcoming generalized notifications. >>  >=20 >>  > * Move definitions of the new functions and some other = >>  functions/structures >>  > used for the routing table manipulation to a separate header file, >>  > net/route/route_ctl.h. net/route.h is a frequently used file = >>  included in >>  > ~140 places in kernel, and 90% of the users don't need these = >>  definitions. >>  >=20 >>  > Reviewed by: ae >>  > Differential Revision: https://reviews.freebsd.org/D25067 >>  >=20 >>  > Modified: >>  > head/sys/net/if_llatbl.c >>  > head/sys/net/route.c >>  > head/sys/net/route.h >>  > head/sys/net/route/nhop_ctl.c >>  > head/sys/net/route/route_ctl.c >>  > head/sys/net/route/route_ddb.c >>  > head/sys/net/route/route_helpers.c >>  > head/sys/net/route/route_temporal.c >>  > head/sys/net/route/route_var.h >>  > head/sys/netinet/in_rmx.c >>  > head/sys/netinet/ip_icmp.c >>  > head/sys/netinet6/icmp6.c >>  > head/sys/netinet6/in6_rmx.c >>  > head/sys/netinet6/nd6_rtr.c >>  >=20 >>  > Modified: head/sys/net/if_llatbl.c >>  > = >>  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= >>  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= >>  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= >>  =3D=3D=3D >>  > --- head/sys/net/if_llatbl.c Mon Jun 1 20:40:40 2020 = >>  (r361705) >>  > +++ head/sys/net/if_llatbl.c Mon Jun 1 20:49:42 2020 = >>  (r361706) >>  > @@ -58,6 +58,7 @@ __FBSDID("$FreeBSD$"); >>  > #include >>  > #include >>  > #include >>  > +#include >>  Where is this file coming from? > > That was in r361704 and reverted in r361705, but should have been in this > commit too. Thanks for the notification and sorry for the breakage. Didn't realise it was not added and was testin another change. Commited back in r361707. > >>  Best regards >>  Michael > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: https://FreeBSD.org > NTP: Web: https://nwtime.org > >         The need of the many outweighs the greed of the few.