From owner-freebsd-fs@freebsd.org Wed May 13 13:07:31 2020 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 32DA02F64EA for ; Wed, 13 May 2020 13:07:31 +0000 (UTC) (envelope-from y.freebsd@paritcher.com) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49MZhf2qyrz431b for ; Wed, 13 May 2020 13:07:30 +0000 (UTC) (envelope-from y.freebsd@paritcher.com) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 77CB45C010A; Wed, 13 May 2020 09:07:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 13 May 2020 09:07:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paritcher.com; h=subject:to:references:from:message-id:date:mime-version :in-reply-to:content-type; s=fm1; bh=oGHIlfQ2ydhwA9g+ojBD2AHXJsq r9/byJAWdPgqSuLc=; b=Bs7HsIeydXYhdfW8eQsAd3W+HcQteHAu/UjeyjNqjmo 3djQ9D/pQNopo6PrMxTSo0sPmv2feXfeTJ4UgCR64uaLTfUZ7dia1VTxlQ62mVsc g4JnGwZgVq/SF0C+UmKr0QmDZsnLIsRaLN5viWCuneL+dkw5TSHGaPzl6yAa6XZu LG/x0KiZ57cuFCIlnntUIFc7/3CCeq40acKC8mgybQ9kIoLqy0Kdnz6zLHWgfUVb FpRaFnu/n7hRQPti3iefLxltHN2etpjnRO2oz2f9lyZOr2fd63yCBKQFlmEDsPu8 7HEg9CjWnlWEQNRII80hR6R9ch/sAXku+fFdNigWBgA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=oGHIlf Q2ydhwA9g+ojBD2AHXJsqr9/byJAWdPgqSuLc=; b=BTvNoBONSoJ5cc6TagfCH5 i/Zgn7Z96ZkCvfQ73YTUp1ScFz4mapcGg2NyBquA9rqmd7pdQme2ifqjBmNjEX76 4oCIiNZbKqExuy64qFYacQgI7lrhyqHGKfF0G9oKEiZnMcOgAcwjJ9Zqcxq+6Zqc 1u0Dlg3lC9ZpPPmhB4Htvh0ft3i48Sl6UhR7xz4iJJQRv9AJpm8jGJW0hBJdrztn HaGEOhTJifB9UKCOhwa6ezV+Q+vUjCbgOHYDVQ7Bzb7fp5CBOq2VgEtBOwa1lsWS HayP0NcdZBSq2Hglr9fc3JBHGF/74W/L3WxGfXVapFU4ErTl2xBa4fDuUtOokhfw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrleeggdeitdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepuffvfhfhkffffgggjggtsegrtderre dtfeejnecuhfhrohhmpegjucfrrghrihhttghhvghruceohidrfhhrvggvsghsugesphgr rhhithgthhgvrhdrtghomheqnecuggftrfgrthhtvghrnhepveduveelveejgeevhefgje fhudfhheffuedtgfduleeivefffefhvefggeeiueegnecuffhomhgrihhnpehgihhthhhu sgdrtghomhdpfhhrvggvsghsugdrohhrghenucfkphepieehrdduvdekrdduleekrdduge ejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhephidr fhhrvggvsghsugesphgrrhhithgthhgvrhdrtghomh X-ME-Proxy: Received: from [192.168.1.201] (65-128-198-147.mpls.qwest.net [65.128.198.147]) by mail.messagingengine.com (Postfix) with ESMTPA id 05AC130662FC for ; Wed, 13 May 2020 09:07:28 -0400 (EDT) Subject: Re: miscalculation in sa_find_sizes() To: freebsd-fs@freebsd.org References: <15b7b666-4137-a4cf-d742-dd0123ff6340@paritcher.com> <0f528106-bc79-c11c-e767-9685d13068ef@FreeBSD.org> From: Y Paritcher Message-ID: <75a38732-b797-df86-b29f-854f6018d2fe@paritcher.com> Date: Wed, 13 May 2020 08:07:28 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <0f528106-bc79-c11c-e767-9685d13068ef@FreeBSD.org> Content-Language: en-US X-Rspamd-Queue-Id: 49MZhf2qyrz431b X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=paritcher.com header.s=fm1 header.b=Bs7HsIey; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=BTvNoBON; dmarc=pass (policy=none) header.from=paritcher.com; spf=pass (mx1.freebsd.org: domain of y.freebsd@paritcher.com designates 66.111.4.29 as permitted sender) smtp.mailfrom=y.freebsd@paritcher.com X-Spamd-Result: default: False [-6.59 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[paritcher.com:s=fm1,messagingengine.com:s=fm2]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RWL_MAILSPIKE_GOOD(0.00)[29.4.111.66.rep.mailspike.net : 127.0.0.18]; R_SPF_ALLOW(-0.20)[+ip4:66.111.4.29]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-fs@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[paritcher.com:+,messagingengine.com:+]; DMARC_POLICY_ALLOW(-0.50)[paritcher.com,none]; IP_SCORE(-3.49)[ip: (-9.85), ipnet: 66.111.4.0/24(-4.89), asn: 11403(-2.69), country: US(-0.05)]; RCVD_IN_DNSWL_LOW(-0.10)[29.4.111.66.list.dnswl.org : 127.0.5.1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:11403, ipnet:66.111.4.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[147.198.128.65.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10] Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 May 2020 13:07:31 -0000 all the details are in the attached bug report in summary: caused by r294812 https://github.com/freebsd/freebsd/commit/71d7abc46e4defbcf77033c417935b944c13084a affects 10.4, 11, 12, and 13 fixed in ZoL commit https://github.com/openzfs/zfs/commit/83021b47c2870c0ba948cbcfe08f41bd7730f5fb with further fixes https://github.com/openzfs/zfs/commit/a62d1b02e372e63862cee276185f2763f641ff10 Yechiel On 5/13/20 2:49 AM, Andriy Gapon wrote: > On 13/05/2020 03:28, Y Paritcher wrote: >> Hi, >> >> >> I am new to FreeBSD, >> >> I reported in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244899 there is >> a miscalculation in sa_find_sizes() in sa.c >> >> This issue was fixed by ZoL. >> >> How should i go about trying to get this patched in FreeBsd 11 12 & 13 ? > Could you please point out the relevant ZoL issue / PR / commit? > Thanks! >