From owner-cvs-src@FreeBSD.ORG Mon Jun 2 20:37:58 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 05299106566C; Mon, 2 Jun 2008 20:37:58 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 8DE4C8FC19; Mon, 2 Jun 2008 20:37:57 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m52KbocJ063672; Mon, 2 Jun 2008 16:37:51 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Stefan Farfeleder Date: Mon, 2 Jun 2008 14:45:15 -0400 User-Agent: KMail/1.9.7 References: <200805151955.m4FJtRMb099378@repoman.freebsd.org> In-Reply-To: <200805151955.m4FJtRMb099378@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200806021445.15974.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Mon, 02 Jun 2008 16:37:51 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/7325/Mon Jun 2 09:45:22 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/bin/sh expand.c parser.c parser.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jun 2008 20:37:58 -0000 On Thursday 15 May 2008 03:55:27 pm Stefan Farfeleder wrote: > stefanf 2008-05-15 19:55:27 UTC > > FreeBSD src repository > > Modified files: > bin/sh expand.c parser.c parser.h > Log: > Expand $LINENO to the current line number. This is required by SUSv3's "User > Portability Utilities" option. > > Often configure scripts generated by the autotools test if $LINENO works and > refuse to use /bin/sh if not. > > Package test run by: pav This breaks the build of editors/openoffice-2 Specifically, the libxslt configure script has two statements like this: if test "1" == "1" then blah blah endif Specifically note the "==" passed to test(1). POSIX says this should be "=", and that's all our test(1) implements. The bash manpage for the builtin-test command says: string1 == string2 True if the strings are equal. = may be used in place of == for strict POSIX compliance. IOW, it encourages "==". I'm not sure if we want to force the use of bash for certain ports or if we want to just implement bash'isms in our tools as we encounter them (or patch the port?). In this case the patch is not complicated (just replace the two '==' with '=' in libxslt's configure script). -- John Baldwin