From owner-cvs-all@FreeBSD.ORG Mon Sep 11 22:27:21 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4748F16A4E2; Mon, 11 Sep 2006 22:27:21 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id ECC0B43E51; Mon, 11 Sep 2006 22:26:04 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k8BMPGhs020821; Mon, 11 Sep 2006 18:25:17 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: John-Mark Gurney Date: Mon, 11 Sep 2006 18:25:08 -0400 User-Agent: KMail/1.9.1 References: <200609112052.k8BKqgFd002566@repoman.freebsd.org> <20060911220857.GN9421@funkthat.com> In-Reply-To: <20060911220857.GN9421@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200609111825.09706.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 11 Sep 2006 18:25:17 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/1860/Mon Sep 11 12:34:08 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/bktr bktr_i2c.c src/sys/dev/ichsmb ichsmb.c src/sys/dev/iicbus iicsmb.c src/sys/dev/smbus smb.c smb.h smbconf.c smbconf.h smbus.c smbus.h smbus_if.m src/sys/pci alpm.c amdpm.c amdsmb.c intpm.c nfsmb.c viapm.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2006 22:27:21 -0000 On Monday 11 September 2006 18:08, John-Mark Gurney wrote: > John Baldwin wrote this message on Mon, Sep 11, 2006 at 20:52 +0000: > > [...] > > > - Change the SMB_BREAD ioctl to write out the updated struct smbcmd which > > will contain the actual number of bytes read in the 'count' field. To > > preserve the previous ABI, the old ioctl value is mapped to SMB_OLD_BREAD > > which doesn't copy the updated smbcmd back out to userland. I doubt anyone > > actually used the old BREAD anyway as it was rediculous to do a bulk-read > > but not tell the using program how much data was actually read. > > [...] > > > - Fix buffer overflows in the bread() methods of ichsmb(4), alpm(4), > > amdpm(4), amdsmb(4), intpm(4), and nfsmb(4). > > The old SMB_BREAD w/o the other change would overflow the buffer w/ > the real amount of data which you had no way to know exactly how much > was overwritten (at least you knew it'd be no more than 32 bytes due to > smbus limitations)... > > I'd vote for removing _OLD_BREAD, and adding it back when merged into > 6.x... 7.0 is as good of a time to change the API... Well, for now I hope to MFC this stuff as the IPMI stuff I'm working on depends on this to handle IPMI over SMBus (SSIF). Once it is MFC'd, then we can remove the old one in 7. -- John Baldwin