From owner-svn-src-head@freebsd.org Wed Jan 23 23:52:00 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D91F214B6266; Wed, 23 Jan 2019 23:51:59 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5265F6AAC1; Wed, 23 Jan 2019 23:51:59 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x430.google.com with SMTP id b85so2008316pfc.3; Wed, 23 Jan 2019 15:51:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=2hejBC73BbVZejQDbUVB6KS6N8Bnn7jx592PNcQ22hU=; b=RU2WSmWTDd3nfbt5ZwgDw74G6qC0o5tkEjdFTxUxFpLDdII4RaUiRsSLaIYODsZpTX 9uXc6CRamir71TLByI1LT26S0mH2LqMcpABA9d0EguJbjbows7T7Ppgzw7YQOxHD+5EC QuF5yif6fPbhAvI4bGJlK4tghsGUYJrSNjqYmLu7I9VmkZmseiq6ADR8YzPStVcBoTRr We96UrDyamEY/IfVpiHE3L6leEsK/JIEHbFL3fPlDjehGe2ezepaq/ljRcr4Th6HQFcB B7YQUxYB3Vm+KImtcOBYbx9ziEhN7gMlAFNDhhfhV2P8O0KFEz8E4mieTpYPl7x6Lkbc sT2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=2hejBC73BbVZejQDbUVB6KS6N8Bnn7jx592PNcQ22hU=; b=RkadDMBLRupOoEfgIs5I9jfCF73PAbgFRs0KVyP1O5BAz20jTMloP02efkB4xC5vIZ boSR+1pqIn0Rp83gpzAPp2OTknIqF2txMbHVQHc5TgkgMpZ67gj1FlOIbgt+8rbjNyYL NjWETsaYDF453ofExyjUlFe5K22BWNggooJUDu9IIPhbE6kmpKtJZbVeDFB66zY4CzDM A/k7oVspjLI0I7q1RCRxeIVnJ2jGYlDOvQK5duCH6QL/NwQfh4bmQqHpGAT69tTx5aOJ TtEptK2He8UvgLrUpYy6ktCVvTHzGayc+BtpZchT8390ZItPAYArF6Y4cPbxCx20i7vg 70LA== X-Gm-Message-State: AJcUukeceQ5k/grni6I10Hijh49fx4alP3Or+hnaaSITL4emAAA5+5GF NoHGMD/pr7dF5T7GZ1BEhVFE0ne3 X-Google-Smtp-Source: ALg8bN6pNTAKCmeFcGdK0M0j0/db5ByWKZCFreMva9jfDR2ArmOvza4d57BjA3oohUNK0mMPvW3PcA== X-Received: by 2002:a63:955a:: with SMTP id t26mr3875745pgn.449.1548287517831; Wed, 23 Jan 2019 15:51:57 -0800 (PST) Received: from [192.168.2.101] (c-24-56-255-165.customer.broadstripe.net. [24.56.255.165]) by smtp.gmail.com with ESMTPSA id w88sm45512002pfk.11.2019.01.23.15.51.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Jan 2019 15:51:57 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: svn commit: r343368 - head/lib/libc/tests/sys From: Enji Cooper In-Reply-To: <201901232348.x0NNmvO5098255@repo.freebsd.org> Date: Wed, 23 Jan 2019 15:51:56 -0800 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201901232348.x0NNmvO5098255@repo.freebsd.org> To: Enji Cooper X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: 5265F6AAC1 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.985,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2019 23:52:00 -0000 > On Jan 23, 2019, at 3:48 PM, Enji Cooper wrote: >=20 > Author: ngie > Date: Wed Jan 23 23:48:57 2019 > New Revision: 343368 > URL: https://svnweb.freebsd.org/changeset/base/343368 >=20 > Log: > Fix up r343367 >=20 > I should have only changed the format qualifier with the `size_t` = value, > `length`, not the other [`off_t`] value, `dest_file_size`. >=20 > MFC after: 1 month > MFC with: r343362, r343365, r343367 > Approved by: emaste (mentor; implicit) > Reported by: gcc 8.x Lessons to learn from this: is, again, always run =E2=80=9Cmake = universe=E2=80=9D beforehand on the releng machines. I swore I did this = before, but I can=E2=80=99t remember (and I didn=E2=80=99t run it before = committing the code). Trying to figure out a reasonable way to use my GitHub fork and = do work with svn =E2=80=94 the workflow is extremely error prone right = now (this is just one symptom of that issue). Thank you for your patience, everyone. It=E2=80=99s been far too = long since I=E2=80=99ve earned pointyhats :/. Cheers, -Enji=