From owner-freebsd-multimedia@FreeBSD.ORG  Fri Aug 16 19:55:21 2013
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
Delivered-To: freebsd-multimedia@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 9BC962E2
 for <freebsd-multimedia@freebsd.org>; Fri, 16 Aug 2013 19:55:21 +0000 (UTC)
 (envelope-from hans.petter.selasky@bitfrost.no)
Received: from mta.bitpro.no (mta.bitpro.no [92.42.64.202])
 by mx1.freebsd.org (Postfix) with ESMTP id 5626A2DC2
 for <freebsd-multimedia@freebsd.org>; Fri, 16 Aug 2013 19:55:20 +0000 (UTC)
Received: from mail.lockless.no (mail.lockless.no [46.29.221.38])
 by mta.bitpro.no (Postfix) with ESMTP id 3351E7A334;
 Fri, 16 Aug 2013 21:55:19 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
 by mail.lockless.no (Postfix) with ESMTP id F04B78EEEDC;
 Fri, 16 Aug 2013 21:55:28 +0200 (CEST)
X-Virus-Scanned: by amavisd-new-2.6.4 (20090625) (Debian) at lockless.no
Received: from mail.lockless.no ([127.0.0.1])
 by localhost (mail.lockless.no [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id mPW7PHYTaUMa; Fri, 16 Aug 2013 21:55:28 +0200 (CEST)
Received: from laptop015.hselasky.homeunix.org
 (cm-176.74.213.204.customer.telag.net [176.74.213.204])
 by mail.lockless.no (Postfix) with ESMTPSA id 4704C8EEEC8;
 Fri, 16 Aug 2013 21:55:28 +0200 (CEST)
Message-ID: <520E83F4.6010307@bitfrost.no>
Date: Fri, 16 Aug 2013 21:56:36 +0200
From: Hans Petter Selasky <hans.petter.selasky@bitfrost.no>
Organization: Bitfrost A/S
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130522 Thunderbird/17.0.6
MIME-Version: 1.0
To: Juergen Lock <nox@jelal.kn-bremen.de>
Subject: Re: New version of webcamd [3.11.0.1] ready for testing
References: <51A10BD5.1050107@bitfrost.no>
 <zarafa.520e5885.7648.5a3ce2f304daebfb@mail.lockless.no>
 <20130816183810.GA16711@triton8.kn-bremen.de>
In-Reply-To: <20130816183810.GA16711@triton8.kn-bremen.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "freebsd-multimedia@freebsd.org" <freebsd-multimedia@freebsd.org>,
 Srinivas Kandagatla <srinivas.kandagatla@st.com>
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-multimedia>, 
 <mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
 <mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Aug 2013 19:55:21 -0000

Hi Srinivas,

Can you submit the patch from Juergen? Thank you!

 >   Ah indeed that is better, now technisat-usb2 works again, including
> it's remote. :)  Here is the patch:
>
> --- media_tree/drivers/media/rc/rc-main.c.orig
> +++ media_tree/drivers/media/rc/rc-main.c
> @@ -707,7 +707,7 @@ int rc_open(struct rc_dev *rdev)
>   		return -EINVAL;
>
>   	mutex_lock(&rdev->lock);
> -	if (!rdev->users++)
> +	if (!rdev->users++ && rdev->open != NULL)
>   		rval = rdev->open(rdev);
>
>   	if (rval)
> @@ -731,7 +731,7 @@ void rc_close(struct rc_dev *rdev)
>   	if (rdev) {
>   		mutex_lock(&rdev->lock);
>
> -		 if (!--rdev->users)
> +		 if (!--rdev->users && rdev->close != NULL)
>   			rdev->close(rdev);
>
>   		mutex_unlock(&rdev->lock);
>> --HPS
>>
>   And now I also tested rtl28xxu, af9015, af9035, ati_remote, mceusb,
> uvc, gspca and they also all worked as before.
>
>   Thanx!
> 	Juergen

I'll wait a bit for the patch to reach V4L GIT and then I'll roll 
another tarball!

Thanks Juergen!

--HPS