From owner-svn-src-head@FreeBSD.ORG Wed Dec 22 14:59:07 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DE85C1065694; Wed, 22 Dec 2010 14:59:07 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 72D208FC23; Wed, 22 Dec 2010 14:59:07 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 2B63446B49; Wed, 22 Dec 2010 09:59:07 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 56DD18A009; Wed, 22 Dec 2010 09:59:06 -0500 (EST) From: John Baldwin To: "Jung-uk Kim" Date: Wed, 22 Dec 2010 08:03:11 -0500 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20101102; KDE/4.4.5; amd64; ; ) References: <201012220018.oBM0IgOg079632@svn.freebsd.org> In-Reply-To: <201012220018.oBM0IgOg079632@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201012220803.12023.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Wed, 22 Dec 2010 09:59:06 -0500 (EST) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216634 - in head/sys/amd64: amd64 ia32 include linux32 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Dec 2010 14:59:08 -0000 On Tuesday, December 21, 2010 7:18:42 pm Jung-uk Kim wrote: > Author: jkim > Date: Wed Dec 22 00:18:42 2010 > New Revision: 216634 > URL: http://svn.freebsd.org/changeset/base/216634 > > Log: > Improve PCB flags handling and make it more robust. Add two new functions > for manipulating pcb_flags. These inline functions are very similar to > atomic_set_char(9) and atomic_clear_char(9) but without unnecessary LOCK > prefix for SMP. Add comments about the rationale[1]. Use these functions > wherever possible. Although there are some places where it is not strictly > necessary (e.g., a PCB is copied to create a new PCB), it is done across > the board for sake of consistency. Turn pcb_full_iret into a PCB flag as > it is safe now. Move rarely used fields before pcb_flags and reduce size > of pcb_flags to one byte. Fix some style(9) nits in pcb.h while I am in > the neighborhood. > > Reviewed by: kib > Submitted by: kib[1] > MFC after: 2 months Is there really a need to have the flags field be a char instead of an int or long? It seems to me that flags fields in general should be an int unless there is a strong need otherwise (e.g. hardware-defined flag). 'orl' will work just as well as 'orb'. -- John Baldwin