Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 16 Feb 2015 21:35:30 +0000 (UTC)
From:      "Pedro F. Giffuni" <pfg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r278867 - head/lib/libcompat/4.3
Message-ID:  <201502162135.t1GLZUpL060886@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pfg
Date: Mon Feb 16 21:35:29 2015
New Revision: 278867
URL: https://svnweb.freebsd.org/changeset/base/278867

Log:
  rexec(3): prevent uninitialized access to "port" variable.
  
  CID:	1018716 (and clang static checker)

Modified:
  head/lib/libcompat/4.3/rexec.c

Modified: head/lib/libcompat/4.3/rexec.c
==============================================================================
--- head/lib/libcompat/4.3/rexec.c	Mon Feb 16 21:26:16 2015	(r278866)
+++ head/lib/libcompat/4.3/rexec.c	Mon Feb 16 21:35:29 2015	(r278867)
@@ -332,10 +332,10 @@ retry:
 		perror(hp->h_name);
 		return (-1);
 	}
-	if (fd2p == 0) {
-		(void) write(s, "", 1);
-		port = 0;
-	} else {
+	port = 0;
+	if (fd2p == 0)
+		(void) write(s, "", 1);	
+	else {
 		char num[8];
 		int s2, sin2len;
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201502162135.t1GLZUpL060886>