Date: Tue, 20 Nov 2001 09:50:01 -0800 (PST) From: Ian Dowse <iedowse@maths.tcd.ie> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/32138: better progress reporting for dump(8) Message-ID: <200111201750.fAKHo1069877@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/32138; it has been noted by GNATS. From: Ian Dowse <iedowse@maths.tcd.ie> To: Mikhail Teterin <mi@aldan.algebra.com> Cc: FreeBSD-gnats-submit@freebsd.org Subject: Re: bin/32138: better progress reporting for dump(8) Date: Tue, 20 Nov 2001 17:41:50 +0000 In message <200111201651.fAKGp7s38773@aldan.algebra.com>, Mikhail Teterin write s: >-void timeest __P((void)); >+void timeest __P((int)); /* accepts the signal number */ >+ signal(SIGINFO, timeest); /* report progress on SIGINFO */ I think it would be cleaner to add a simple signal handler which sets a flag, and then check this where necessary. Calling a signal handler function directly is weird, and using a magic value for the signal number is evil :-) What happens if multiple ^Ts are sent and tschedule gets decremented a few times in a row? Ian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200111201750.fAKHo1069877>