From owner-cvs-src@FreeBSD.ORG Wed Oct 5 20:05:52 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B223A16A41F; Wed, 5 Oct 2005 20:05:52 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8103543D46; Wed, 5 Oct 2005 20:05:52 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j95K5qtt065815; Wed, 5 Oct 2005 20:05:52 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j95K5qMh065814; Wed, 5 Oct 2005 20:05:52 GMT (envelope-from netchild) Message-Id: <200510052005.j95K5qMh065814@repoman.freebsd.org> From: Alexander Leidinger Date: Wed, 5 Oct 2005 20:05:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/pci als4000.c via8233.c via82c686.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2005 20:05:52 -0000 netchild 2005-10-05 20:05:52 UTC FreeBSD src repository Modified files: sys/dev/sound/pci als4000.c via8233.c via82c686.c Log: - Locking improvements. - Don't keep the SPDIF state in the driver private struct since it can be overriden by hand with pciconf(8), query it when needed instead. Regarding the locking I let Ariff explain it himself: ---snip--- About the locking, that is what I'm intended to do since the beginning. The reason I'm not putting that along since my first patchset was because several people especially from amd46 camp reported that it cause lots of LORs, which is weird considering that I've never encounter such in a pretty much strict locking environment (i386). However, since our previous discussion with Pyun YongHyeon about strict locking, I've decided to bring it back for all the affected drivers, not just for es137x. It turns out that the root of the problem was within dsp.c during device open, which has been fixed since dsp.c revision 1.84. ---snip--- Submitted by: Ariff Abdullah Revision Changes Path 1.21 +15 -0 src/sys/dev/sound/pci/als4000.c 1.22 +24 -20 src/sys/dev/sound/pci/via8233.c 1.37 +8 -2 src/sys/dev/sound/pci/via82c686.c