Date: Tue, 10 Oct 2023 00:56:10 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 274383] mail/aerc: Update to 0.16.0 and take maintainership Message-ID: <bug-274383-7788-NUUfNe5SIp@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-274383-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-274383-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274383 --- Comment #2 from Robert Clausecker <fuz@FreeBSD.org> --- Is there a changelog for this update? Instead of moving the Makefile, you can set the MAKEFILE variable to the ac= tual name of the Makefile. You might want to change the port so it uses the GO_MODULE mechanism to have the Go tooling download the required files (if that works in this case). T= his would remove the need for all the complicated handling of extra dependencie= s. The port currently ignores CFLAGS and CPPFLAGS. Make sure it respects them= . I can see this as the output has cc -O2 -g -o colorize filters/colorize.c without the usual -fstack-protector-strong etc. This can perhaps be fixed = by invoking make properly (and please do it separately for build and install if possible): (cd ${WRKSRC} && ${DO_MAKE_BUILD} ${ALL_TARGET}) and later to install, (cd ${WRKSRC} && ${DO_MAKE_BUILD} ${INSTALL_TARGET}) If you have USES=3Dgmake, this automatically picks GNUmake. Furthermore, make sure installed binaries are stripped. stage-qa complains: =3D=3D=3D=3D> Running Q/A tests (stage-qa) Warning: 'libexec/aerc/filters/colorize' is not stripped consider trying INSTALL_TARGET=3Dinstall-strip or using ${STRIP_CMD} Warning: 'libexec/aerc/filters/wrap' is not stripped consider trying INSTALL_TARGET=3Dinstall-strip or using ${STRIP_CMD} Warning: you might not need LIB_DEPENDS on libnotmuch.so Also please set VERSION in MAKE_ARGS so the port doesn't try to invoke git = to find the version (this frequently goes wrong if the ports tree is managed v= ia git; go figure). In fact, since we build the main binary via USES=3Dgo's d= efault do-build rule, you should also carry over all the other bits that go into GO_BUILDFLAGS. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-274383-7788-NUUfNe5SIp>