From owner-svn-src-all@FreeBSD.ORG Tue Oct 14 14:49:07 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F2D2D1065692 for ; Tue, 14 Oct 2008 14:49:07 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.186]) by mx1.freebsd.org (Postfix) with ESMTP id 7FB5E8FC16 for ; Tue, 14 Oct 2008 14:49:07 +0000 (UTC) (envelope-from max@love2party.net) Received: from vampire.homelinux.org (dslb-088-066-016-013.pools.arcor-ip.net [88.66.16.13]) by mrelayeu.kundenserver.de (node=mrelayeu5) with ESMTP (Nemesis) id 0ML25U-1KplCs098I-0000rL; Tue, 14 Oct 2008 16:49:06 +0200 Received: (qmail 320 invoked from network); 14 Oct 2008 14:49:05 -0000 Received: from fbsd8.laiers.local (192.168.4.151) by laiers.local with SMTP; 14 Oct 2008 14:49:05 -0000 From: Max Laier Organization: FreeBSD To: Roman Kurakin Date: Tue, 14 Oct 2008 16:49:04 +0200 User-Agent: KMail/1.10.1 (FreeBSD/8.0-CURRENT; KDE/4.1.1; i386; ; ) References: <200810141226.m9ECQtPW006469@svn.freebsd.org> <48F4A9A5.8020605@inse.ru> In-Reply-To: <48F4A9A5.8020605@inse.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200810141649.04834.max@love2party.net> X-Provags-ID: V01U2FsdGVkX1/aLStA+TWL0zwk0a7H05+sntrke48BvYuIfqi xNrxeMwD0pe0nG5CpgxdFkTChKTXWY2ppQKHsRt1jEi7MNQPja PLIERzbirY4pFafys7MVg== Cc: Maxim Konovalov , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r183881 - head/sys/netinet X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Oct 2008 14:49:08 -0000 On Tuesday 14 October 2008 16:16:05 Roman Kurakin wrote: > Maxim Konovalov: > > Author: maxim > > Date: Tue Oct 14 12:26:55 2008 > > New Revision: 183881 > > URL: http://svn.freebsd.org/changeset/base/183881 > > > > Log: > > o Reformat ipfw nat get|setsockopt code to look it more > > style(9) compliant. No functional changes. > > > > Modified: > > head/sys/netinet/ip_fw2.c > > > > Modified: head/sys/netinet/ip_fw2.c > > ========================================================================= > >===== --- head/sys/netinet/ip_fw2.c Tue Oct 14 10:23:11 2008 (r183880) +++ > > head/sys/netinet/ip_fw2.c Tue Oct 14 12:26:55 2008 (r183881) @@ -4385,49 > > +4385,52 @@ ipfw_ctl(struct sockopt *sopt) > > break; > > > > case IP_FW_NAT_CFG: > > - { > > - if (IPFW_NAT_LOADED) > > - error = ipfw_nat_cfg_ptr(sopt); > > - else { > > - printf("IP_FW_NAT_CFG: ipfw_nat not present, please load it.\n"); > > - error = EINVAL; > > + { > > + if (IPFW_NAT_LOADED) > > + error = ipfw_nat_cfg_ptr(sopt); > > + else { > > + printf("IP_FW_NAT_CFG: %s\n", > > + "ipfw_nat not present, please load it"); > > + error = EINVAL; > > + } > > } > > IMHO such indention does not add any usefulness, but increases indention > level that is already very high. > Also I do not see strict contradiction to the style(9), but probably I > am not reading the most current style(9). The additional scope is absolutely unnecessary here and should be dropped - IMHO. See case IP_FW_RESETLOG and above. -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News