From owner-freebsd-hackers Sat Jun 10 0:31:20 2000 Delivered-To: freebsd-hackers@freebsd.org Received: from falla.videotron.net (falla.videotron.net [205.151.222.106]) by hub.freebsd.org (Postfix) with ESMTP id 08D8137C691; Sat, 10 Jun 2000 00:31:11 -0700 (PDT) (envelope-from bmilekic@dsuper.net) Received: from modemcable009.62-201-24.mtl.mc.videotron.net ([24.201.62.9]) by falla.videotron.net (Sun Internet Mail Server sims.3.5.1999.12.14.10.29.p8) with ESMTP id <0FVX00HBNGK4YO@falla.videotron.net>; Sat, 10 Jun 2000 03:24:05 -0400 (EDT) Date: Sat, 10 Jun 2000 03:25:43 -0400 (EDT) From: Bosko Milekic Subject: Re: Mbuf waiting mfc to 3 In-reply-to: X-Sender: bmilekic@jehovah.technokratis.com To: Mike Silbersack Cc: hackers@FreeBSD.ORG, jlemon@freebsd.org Message-id: MIME-version: 1.0 Content-type: MULTIPART/MIXED; BOUNDARY="Boundary_(ID_fqHP9plKj2pR4F46G+zSsw)" Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --Boundary_(ID_fqHP9plKj2pR4F46G+zSsw) Content-type: TEXT/PLAIN; charset=US-ASCII [re-directed to --hackers, as more appropriate there, also jlemon@freebsd.org is in the CC, make _SURE_ to remove him from there before you post ANY replies!!!] Mike, your patch looks fine. However, I found a bug in /sys/netkey code. (and it's related to the wait stuff, although I don't believe it directly concerns your patch so, as far as I'm concerned, your stuff is ready to go in.) However, I believe this code is only for 4.x and -CURRENT people. keysock.c's key_sendup() does a silly thing with the mbuf allocation. Attached is a patch that fixes it. This applies to v 1.2 of the file. here is the Id: /* KAME @(#)$Id: keysock.c,v 1.2 1999/08/16 19:30:36 shin Exp $ */ (Jlemon, can you commit this?) Oh yeah, and please also commit pr=18471 as it's been sitting there for a while. Thanks in advance, Bosko. On Fri, 9 Jun 2000, Mike Silbersack wrote: > Well, it's been nearly a month since I posted the mbuf waiting MFC for 3.4 > to -net, although I haven't heard any complaints about it messing up > systems, there have been a few complaints on bugtraq of mbuf > exhaustion attacks which would be much less serious with it. :) > > In any case, the patch is still available at > http://www.silby.com/patches/mbuf-wait-mfc-2.patch for review. I'm > fairly confident in its reliability, but I'd prefer a few more people to > test it if they have the time. If there are no negative complaints, I'd > like to get it committed before the end of next week to ensure that we > don't miss getting it into 3.5. > > There are no changes between this patch and the last one I posted other > than a single version line I had messed up in the previous one, so if > you're currently testing that one, there's no need to download this > one. Please post your experiences with it in any case, though. > > The small memory leak I alluded to in my previous posting of the patch has > been found and committed seperately (as it affected 3,4, and 5.) So, > please CVSUP before testing this patch to ensure you're seeing its true > colors. > > Thanks, > > Mike "Silby" Silbersack -- Bosko Milekic * Voice/Mobile: 514.865.7738 * Pager: 514.921.0237 bmilekic@technokratis.com * http://www.technokratis.com/ --Boundary_(ID_fqHP9plKj2pR4F46G+zSsw) Content-id: Content-type: TEXT/PLAIN; name=keysock.patch; charset=US-ASCII Content-description: Content-disposition: attachment; filename=keysock.patch Content-transfer-encoding: BASE64 LS0tIGtleXNvY2sub2xkLmMJU2F0IEp1biAxMCAwMzowOTowNSAyMDAwDQor Kysga2V5c29jay5jCVNhdCBKdW4gMTAgMDM6MTM6NDMgMjAwMA0KQEAgLTQx OSwxOCArNDE5LDI1IEBADQogCXdoaWxlICh0bGVuID4gMCkgew0KIAkJaWYg KHRsZW4gPT0gbGVuKSB7DQogCQkJTUdFVEhEUihuLCBNX0RPTlRXQUlULCBN VF9EQVRBKTsNCisJCQlpZiAobiA9PSBOVUxMKSB7DQorCQkJCWlmIChtKSBt X2ZyZWVtKG0pOw0KKwkJCQlyZXR1cm4gRU5PQlVGUzsNCisJCQl9DQogCQkJ bi0+bV9sZW4gPSBNSExFTjsNCiAJCX0gZWxzZSB7DQogCQkJTUdFVChuLCBN X0RPTlRXQUlULCBNVF9EQVRBKTsNCisJCQlpZiAobiA9PSBOVUxMKSB7DQor CQkJCWlmIChtKSBtX2ZyZWVtKG0pOw0KKwkJCQlyZXR1cm4gRU5PQlVGUzsN CisJCQl9DQogCQkJbi0+bV9sZW4gPSBNTEVOOw0KIAkJfQ0KLQkJaWYgKCFu KQ0KLQkJCXJldHVybiBFTk9CVUZTOw0KKw0KIAkJaWYgKHRsZW4gPiBNQ0xC WVRFUykgewkvKlhYWCBiZXR0ZXIgdGhyZXNob2xkPyAqLw0KIAkJCU1DTEdF VChuLCBNX0RPTlRXQUlUKTsNCiAJCQlpZiAoKG4tPm1fZmxhZ3MgJiBNX0VY VCkgPT0gMCkgew0KIAkJCQltX2ZyZWUobik7DQotCQkJCW1fZnJlZW0obSk7 DQorCQkJCWlmIChtKSBtX2ZyZWVtKG0pOw0KIAkJCQlyZXR1cm4gRU5PQlVG UzsNCiAJCQl9DQogCQkJbi0+bV9sZW4gPSBNQ0xCWVRFUzsNCg== --Boundary_(ID_fqHP9plKj2pR4F46G+zSsw)-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message