From owner-freebsd-scsi Sun Jan 11 03:15:26 1998 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id DAA13254 for freebsd-scsi-outgoing; Sun, 11 Jan 1998 03:15:26 -0800 (PST) (envelope-from owner-freebsd-scsi) Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id DAA13232 for ; Sun, 11 Jan 1998 03:15:22 -0800 (PST) (envelope-from j@uriah.heep.sax.de) Received: (from uucp@localhost) by sax.sax.de (8.8.8/8.8.8) with UUCP id MAA15343; Sun, 11 Jan 1998 12:15:19 +0100 (CET) (envelope-from j@uriah.heep.sax.de) Received: (from j@localhost) by uriah.heep.sax.de (8.8.8/8.8.5) id MAA27778; Sun, 11 Jan 1998 12:12:12 +0100 (MET) Message-ID: <19980111121211.42324@uriah.heep.sax.de> Date: Sun, 11 Jan 1998 12:12:11 +0100 From: J Wunsch To: freebsd-scsi@FreeBSD.ORG Cc: Carl.Makin@aipo.gov.au Subject: Re: seagate.c kernel compile error and sea device problems. Reply-To: Joerg Wunsch References: <4A256589.001DDBEF.00@notes.aipo.gov.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.88 In-Reply-To: <4A256589.001DDBEF.00@notes.aipo.gov.au>; from Carl.Makin@aipo.gov.au on Sun, Jan 11, 1998 at 03:23:13PM +1000 X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E Sender: owner-freebsd-scsi@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk As Carl.Makin@aipo.gov.au wrote: > Under FreeBSD 2.2.5-RELEASE, > > I get the following error from seagate.c when I compile a kernel. They are not errors, but warnings. You wouldn't have got a kernel at all otherwise. ;) > ../../i386/isa/seagate.c ../../i386/isa/seagate.c:581: warning: no previous > prototype for `seaintr' ../../i386/isa/seagate.c: In function (Your mailer clobbers long lines.) That's sloppyness, but unless the functions are being used differently than defined, it's totally benign. > `sea_data_output': ../../i386/isa/seagate.c:1111: warning: assignment > discards `volatile' from pointer target type ../../i386/isa/seagate.c: In > function `sea_data_input': ../../i386/isa/seagate.c:1181: warning: > assignment discards `volatile' from pointer target type sh The argument p_data should probably be spelled with `volatile' consistently throughout the driver. gcc is not likely to optimize accesses away on an x86 CPU outside of functions, however. ;-) > I uncommented the "BLINDTRANSFERS" option and tried again with the > autodetect sea0 config line and the errors started again. There's probably nobody around anymore understanding the code better than you do these days. :) -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)