From owner-svn-ports-all@FreeBSD.ORG Sat Sep 21 13:43:56 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id D932CD54; Sat, 21 Sep 2013 13:43:56 +0000 (UTC) (envelope-from bf1783@gmail.com) Received: from mail-ie0-x22a.google.com (mail-ie0-x22a.google.com [IPv6:2607:f8b0:4001:c03::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 82BFE2FA2; Sat, 21 Sep 2013 13:43:56 +0000 (UTC) Received: by mail-ie0-f170.google.com with SMTP id x13so3205546ief.15 for ; Sat, 21 Sep 2013 06:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=aZFfsh/fnZqEhK+QFEyF+y6UiX/u9MzxbQ5I08xR3bw=; b=Gn5ANx7S2mYeB90TsjvJg+Pey4wtoph211w4C9Ui9vuVzR0kRrI0ad/OK+LRpdvrKP aa+sbEGuYsCWPusceGqcso9zIkBUssfA7ODG1XUsS2LpA68azS0lxAAee9lYXqW+dyKK eEoZYpYIO+oV/Lf5xLQ0rIh6F4zCdZriz4tBlv1Fn94w4rb5haPEnpeFER2j+xa9ZUuH Qs2tt7dsfO6GesDe/gqUX50r0xmbpQCCjKpgrOlTKYqlMrQKZP3tzXlqknYKnq9E6fmZ 8IjjylSKAgHWTWLgjdpB2WUkx343tCLH5NwaPGVB83UIxTcI3qDq9v0BFHmETpxH4i3A a1KQ== MIME-Version: 1.0 X-Received: by 10.50.40.6 with SMTP id t6mr5991674igk.32.1379771035802; Sat, 21 Sep 2013 06:43:55 -0700 (PDT) Received: by 10.64.86.115 with HTTP; Sat, 21 Sep 2013 06:43:55 -0700 (PDT) In-Reply-To: References: <201309190805.r8J855cW009011@svn.freebsd.org> <3D05DDAC-CF76-4109-9182-6DDAD924CCC5@gahr.ch> <20130920160700.GN73535@ithaqua.etoilebsd.net> Date: Sat, 21 Sep 2013 13:43:55 +0000 Message-ID: Subject: Re: svn commit: r327601 - head/Mk From: Brendan Fabeny To: Sunpoet Po-Chuan Hsieh Content-Type: text/plain; charset=ISO-8859-1 Cc: "svn-ports-head@freebsd.org" , Baptiste Daroussin , ports-committers , "svn-ports-all@freebsd.org" , Pietro Cerutti X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: bf1783@gmail.com List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Sep 2013 13:43:56 -0000 On 9/21/13, Sunpoet Po-Chuan Hsieh wrote: > On Sat, Sep 21, 2013 at 12:07 AM, Baptiste Daroussin > wrote: > >> On Fri, Sep 20, 2013 at 05:27:18PM +0200, Pietro Cerutti wrote: >> > >> > On 20-set-2013, at 10:32, Sunpoet Po-Chuan Hsieh >> wrote: >> > >> > > Hi Bapt, >> > > >> > > May I suggest to change hard-coded sleep time to a settable variable >> defaults to 10? It would save time while checking multiple ports with >> terminal outputs redirected to a log file. >> > >> > Definitely +1 >> > >> I would be all for it, send me a patch and I will approve :) >> >> regards, >> Bapt >> > > A simple patch is here [1]. Thanks. > > [1] http://people.FreeBSD.org/~sunpoet/bsd.port.mk-sleep.patch It seems to me that having more than one configurable wait variable is overkill: there should be one and it should also cover the sleep in identify-install-conflicts; and it should default to 0 when BATCH or PACKAGE_BUILDING is set. I also do not think we should bother to include bsd.sanity.mk when DEVELOPER isn't set -- it is needless added work. b.