From nobody Mon Apr 29 14:37:37 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VSmBn4CSKz5JSRY; Mon, 29 Apr 2024 14:37:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VSmBn3d7rz4LGg; Mon, 29 Apr 2024 14:37:37 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714401457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Z+AlEKgZ7NWywdMo2FneL7NIDAaV1D6JaI9enB0XBG4=; b=HDCtiltY5C34GKG0xLGq3Ji0AMdZEOkfve8IWpVqvloyo7pxnoJw7IZ5RvbP5R8Xr95pfm Pk0q57XQoDkyK8PYRrYNMp98YUzlwzEkjrFt1nKfBc4RQ40Dsym469knAeeAbPKHW/5rMJ K8gIf44DdXsoyVKJkX4divlMnaZ+9o6m2aB4sUh+QA1YyTsbMLpRnZryFKiY5Vy7DB60sn nBU7J0iq2mxPZChh4au/vpkjiXm5Wc6ZfPmKUY/8++z1bHMu8ZjPz1Up7OlUqIm1Wq/JcD wxlXfxX1jJjhmmSR1Q0OMyYgso4oO8awkm/JYiQdUfnCD5XA5tYqsBNtKMwyrg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714401457; a=rsa-sha256; cv=none; b=dv+k9MaDjrF9a8Xd5KtWXnNIaPs31iZUZVq2jGyVU1Mplt+22Pc2Bpbj42KFZ0LDzx2yJK 41Zn3OKKF4EboKXKq9Y6cE0ZCMCq+mZlHl0YWtADDp4XHRDvjqSPYVpP83GtwwI5MBACft VgIbpMiUtXLjuZ2rc23SrC4PSlnHXPK/lu+YqB6DS38p0lJeuWdmal6OOUaePrHcI/0M1K +MzIPu8Jv/K+UuJsPBgiFh35lHTs6E6yLx7VAnXNu0tdzN38h/b3CXdqZIYhKNOaZ6UZU/ fpxwxOUXTZErQnif7gz0FXcFjDuJYRWpYJKcWuxfGmYAOtCAubcyHrcNdm86Fw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714401457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Z+AlEKgZ7NWywdMo2FneL7NIDAaV1D6JaI9enB0XBG4=; b=TI1g0rSYqIaEPGwmMJZtg6bmcrnJrVBMjcqNdoHQZBqMhE8aiqeYyYqp8EnI0edYNhUG/R x0VKMCPWd5Xdh2CACjo6AK+IX0mUt5g+VewWDRG8W+MKeBgUAtXfyxKNenfHFUzfsovZnl rGThKyKh/9Xo8eLMEID4VqH4v83ARkrnntEbh6h6PSOX2mxB/FDJ9RQY7CovuZSRWBMHZa NkNHcjTo6MqKco9xCooQ7pFRvL03JOMVzNY3rtojHGnxrAcPWFYAQnCe6Jpbw7emvQj7Oy joRAwnk4BkCIkx1ffTOyC5AduI4Tr735eqdBU7tBCShIep4jrDgZIQio9XOddA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VSmBn3Cc4z1Bkc; Mon, 29 Apr 2024 14:37:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43TEbbtn080925; Mon, 29 Apr 2024 14:37:37 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43TEbbJS080922; Mon, 29 Apr 2024 14:37:37 GMT (envelope-from git) Date: Mon, 29 Apr 2024 14:37:37 GMT Message-Id: <202404291437.43TEbbJS080922@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 86fbb05da1ae - main - ctl: Fix CTL GET EVENT STATUS NOTIFICATION valid bits List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 86fbb05da1aed64eb9b09d7f3b2cd72048c959c1 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=86fbb05da1aed64eb9b09d7f3b2cd72048c959c1 commit 86fbb05da1aed64eb9b09d7f3b2cd72048c959c1 Author: HP van Braam AuthorDate: 2024-04-29 14:34:46 +0000 Commit: Warner Losh CommitDate: 2024-04-29 14:37:30 +0000 ctl: Fix CTL GET EVENT STATUS NOTIFICATION valid bits Linux as an initiator periodically sends the following to SCSI cdrom devices: 4a 01 00 00 10 00 00 00 08 00 According to the ctl_cmd_entry for this command this is invalid which leads to a lot of failed SCSI commands. The mask in this commit is based off of an early draft of the mmc standard, https://www.t10.org/ftp/t10/document.97/97-108r0.pdf, as well as subsequent standards (mmc2 through mmc6). This solves the issue with Linux initiators. Signed-off-by: HP van Braam Reviewed by: imp, mav Pull Request: https://github.com/freebsd/freebsd-src/pull/1201 --- sys/cam/ctl/ctl_cmd_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/cam/ctl/ctl_cmd_table.c b/sys/cam/ctl/ctl_cmd_table.c index a62c5e8c1e81..28d937edd7dc 100644 --- a/sys/cam/ctl/ctl_cmd_table.c +++ b/sys/cam/ctl/ctl_cmd_table.c @@ -1228,7 +1228,7 @@ const struct ctl_cmd_entry ctl_cmd_table[256] = CTL_CMD_FLAG_ALLOW_ON_PR_RESV | CTL_FLAG_DATA_IN, CTL_LUN_PAT_NONE, - 10, {0x02, 0x01, 0, 0, 0, 0xff, 0xff, 0xff, 0x07}}, + 10, {0xe1, 0, 0, 0x7e, 0, 0, 0xff, 0xff, 0x07}}, /* 4B PAUSE/RESUME */ {NULL, CTL_SERIDX_INVLD, CTL_CMD_FLAG_NONE, CTL_LUN_PAT_NONE},