From owner-cvs-src-old@FreeBSD.ORG Fri Mar 25 18:23:33 2011 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D3F0D1065679 for ; Fri, 25 Mar 2011 18:23:33 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C301A8FC17 for ; Fri, 25 Mar 2011 18:23:33 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id p2PINXKu054936 for ; Fri, 25 Mar 2011 18:23:33 GMT (envelope-from avg@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id p2PINXTZ054935 for cvs-src-old@freebsd.org; Fri, 25 Mar 2011 18:23:33 GMT (envelope-from avg@repoman.freebsd.org) Message-Id: <201103251823.p2PINXTZ054935@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to avg@repoman.freebsd.org using -f From: Andriy Gapon Date: Fri, 25 Mar 2011 18:23:10 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/libexec/rtld-elf rtld.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2011 18:23:33 -0000 avg 2011-03-25 18:23:10 UTC FreeBSD src repository Modified files: libexec/rtld-elf rtld.c Log: SVN rev 220004 on 2011-03-25 18:23:10Z by avg rtld: eliminate double call to close(2) that may occur in load_object The second close(2) call resulted in heisenbugs in some multi-threaded applications where e.g. dlopen(3) call in one thread could close a file descriptor for a file having been opened in other thread concurrently. My litmus test for this issue was an openoffice.org build. Reviewed by: jhb MFC after: 2 weeks Revision Changes Path 1.174 +2 -5 src/libexec/rtld-elf/rtld.c